Bug 40250

Summary: Wrong link to NoIssuesChargeGuarantorWithGuarantees in patron category page
Product: Koha Reporter: Caroline Cyr La Rose <caroline.cyr-la-rose>
Component: Staff interfaceAssignee: Caroline Cyr La Rose <caroline.cyr-la-rose>
Status: Pushed to main --- QA Contact: Marcel de Rooy <m.de.rooy>
Severity: normal    
Priority: P5 - low CC: gmcharlt, lucas, m.de.rooy
Version: MainKeywords: release-notes-needed
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: Small patch Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
25.11.00
Circulation function:
Attachments: Bug 40250: Wrong link to NoIssuesChargeGuarantorWithGuarantees in patron category page
Bug 40250: Terminology changes 'preference' to 'system preference'
Bug 40250: Wrong link to NoIssuesChargeGuarantorWithGuarantees in patron category page
Bug 40250: Terminology changes 'preference' to 'system preference'
Bug 40250: Wrong link to NoIssuesChargeGuarantorWithGuarantees in patron category page
Bug 40250: Terminology changes 'preference' to 'system preference'

Description Caroline Cyr La Rose 2025-06-26 15:03:44 UTC
I noticed while translating that the link to the NoIssuesChargeGuarantorsWithGuarantees syspref in the patron category settings page is a link to NoIssuesChargeGuarantees. A simple copy-paste error I think.

To recreate:
1. Go to Administration > Patron categories
2. Click New category
--> Notice the hint under "Guarantors with guarantees checkout charge limit" is to the NoIssuesChargeGuarantees system preference rather than NoIssuesChargeGuarantorsWithGuarantees
Comment 1 Caroline Cyr La Rose 2025-06-26 15:16:59 UTC
Created attachment 183547 [details] [review]
Bug 40250: Wrong link to NoIssuesChargeGuarantorWithGuarantees in patron category page

This patch corrects the link to the NoIssuesChargeGuarantorsWithGuarantees
system preference in the patron category creation/modification page.

To test:
1. Apply patch
2. Go to Administration > Patron categories
3. Click 'New category'
4. Check that the hint under 'Guarantors with guarantees checkout charge
   limit' links to the correct system preference
5. Click on the link and make sure it links to the correct system preference
Comment 2 Caroline Cyr La Rose 2025-06-26 15:17:01 UTC
Created attachment 183548 [details] [review]
Bug 40250: Terminology changes 'preference' to 'system preference'

This patch corrects the terminology used in the patron category settings
page, changing 'preference' to 'system preference'.
https://wiki.koha-community.org/wiki/Terminology#P

To test:
1. Apply patch
2. Go to Administration > Patron categories
3. Click 'New category'
4. Check that the hints under 'Checkout charge limit', 'Guarantees
   checkout charge limit', and 'Guarantors with guarantees checkout
   charge limit' use 'system preference' and not 'preference'
Comment 3 Caroline Cyr La Rose 2025-06-26 15:18:37 UTC
I also added a patch to correct terminology. We should use 'system preference', not 'preference' https://wiki.koha-community.org/wiki/Terminology#P

Let me know if I should move this to a different bug report...
Comment 4 Owen Leonard 2025-06-26 16:51:50 UTC
Created attachment 183554 [details] [review]
Bug 40250: Wrong link to NoIssuesChargeGuarantorWithGuarantees in patron category page

This patch corrects the link to the NoIssuesChargeGuarantorsWithGuarantees
system preference in the patron category creation/modification page.

To test:
1. Apply patch
2. Go to Administration > Patron categories
3. Click 'New category'
4. Check that the hint under 'Guarantors with guarantees checkout charge
   limit' links to the correct system preference
5. Click on the link and make sure it links to the correct system preference
Comment 5 Owen Leonard 2025-06-26 16:51:54 UTC
Created attachment 183555 [details] [review]
Bug 40250: Terminology changes 'preference' to 'system preference'

This patch corrects the terminology used in the patron category
settings page, changing 'preference' to 'system preference'.
https://wiki.koha-community.org/wiki/Terminology#P

To test:
1. Apply patch
2. Go to Administration > Patron categories
3. Click 'New category'
4. Check that the hints under 'Checkout charge limit', 'Guarantees
   checkout charge limit', and 'Guarantors with guarantees checkout
   charge limit' use 'system preference' and not 'preference'

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 6 Marcel de Rooy 2025-06-27 07:46:22 UTC
Created attachment 183587 [details] [review]
Bug 40250: Wrong link to NoIssuesChargeGuarantorWithGuarantees in patron category page

This patch corrects the link to the NoIssuesChargeGuarantorsWithGuarantees
system preference in the patron category creation/modification page.

To test:
1. Apply patch
2. Go to Administration > Patron categories
3. Click 'New category'
4. Check that the hint under 'Guarantors with guarantees checkout charge
   limit' links to the correct system preference
5. Click on the link and make sure it links to the correct system preference

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 7 Marcel de Rooy 2025-06-27 07:46:23 UTC
Created attachment 183588 [details] [review]
Bug 40250: Terminology changes 'preference' to 'system preference'

This patch corrects the terminology used in the patron category
settings page, changing 'preference' to 'system preference'.
https://wiki.koha-community.org/wiki/Terminology#P

To test:
1. Apply patch
2. Go to Administration > Patron categories
3. Click 'New category'
4. Check that the hints under 'Checkout charge limit', 'Guarantees
   checkout charge limit', and 'Guarantors with guarantees checkout
   charge limit' use 'system preference' and not 'preference'

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 8 Lucas Gass (lukeg) 2025-06-30 14:32:41 UTC
Nice work everyone!

Pushed to main for 25.11