Description
Caroline Cyr La Rose
2025-06-26 15:03:44 UTC
Created attachment 183547 [details] [review] Bug 40250: Wrong link to NoIssuesChargeGuarantorWithGuarantees in patron category page This patch corrects the link to the NoIssuesChargeGuarantorsWithGuarantees system preference in the patron category creation/modification page. To test: 1. Apply patch 2. Go to Administration > Patron categories 3. Click 'New category' 4. Check that the hint under 'Guarantors with guarantees checkout charge limit' links to the correct system preference 5. Click on the link and make sure it links to the correct system preference Created attachment 183548 [details] [review] Bug 40250: Terminology changes 'preference' to 'system preference' This patch corrects the terminology used in the patron category settings page, changing 'preference' to 'system preference'. https://wiki.koha-community.org/wiki/Terminology#P To test: 1. Apply patch 2. Go to Administration > Patron categories 3. Click 'New category' 4. Check that the hints under 'Checkout charge limit', 'Guarantees checkout charge limit', and 'Guarantors with guarantees checkout charge limit' use 'system preference' and not 'preference' I also added a patch to correct terminology. We should use 'system preference', not 'preference' https://wiki.koha-community.org/wiki/Terminology#P Let me know if I should move this to a different bug report... Created attachment 183554 [details] [review] Bug 40250: Wrong link to NoIssuesChargeGuarantorWithGuarantees in patron category page This patch corrects the link to the NoIssuesChargeGuarantorsWithGuarantees system preference in the patron category creation/modification page. To test: 1. Apply patch 2. Go to Administration > Patron categories 3. Click 'New category' 4. Check that the hint under 'Guarantors with guarantees checkout charge limit' links to the correct system preference 5. Click on the link and make sure it links to the correct system preference Created attachment 183555 [details] [review] Bug 40250: Terminology changes 'preference' to 'system preference' This patch corrects the terminology used in the patron category settings page, changing 'preference' to 'system preference'. https://wiki.koha-community.org/wiki/Terminology#P To test: 1. Apply patch 2. Go to Administration > Patron categories 3. Click 'New category' 4. Check that the hints under 'Checkout charge limit', 'Guarantees checkout charge limit', and 'Guarantors with guarantees checkout charge limit' use 'system preference' and not 'preference' Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 183587 [details] [review] Bug 40250: Wrong link to NoIssuesChargeGuarantorWithGuarantees in patron category page This patch corrects the link to the NoIssuesChargeGuarantorsWithGuarantees system preference in the patron category creation/modification page. To test: 1. Apply patch 2. Go to Administration > Patron categories 3. Click 'New category' 4. Check that the hint under 'Guarantors with guarantees checkout charge limit' links to the correct system preference 5. Click on the link and make sure it links to the correct system preference Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 183588 [details] [review] Bug 40250: Terminology changes 'preference' to 'system preference' This patch corrects the terminology used in the patron category settings page, changing 'preference' to 'system preference'. https://wiki.koha-community.org/wiki/Terminology#P To test: 1. Apply patch 2. Go to Administration > Patron categories 3. Click 'New category' 4. Check that the hints under 'Checkout charge limit', 'Guarantees checkout charge limit', and 'Guarantors with guarantees checkout charge limit' use 'system preference' and not 'preference' Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Nice work everyone! Pushed to main for 25.11 |