Bug 40265

Summary: t/db_dependent/OAI/Server.t is failing randomly
Product: Koha Reporter: Lucas Gass (lukeg) <lucas>
Component: Architecture, internals, and plumbingAssignee: Jonathan Druart <jonathan.druart>
Status: Pushed to main --- QA Contact: Marcel de Rooy <m.de.rooy>
Severity: normal    
Priority: P5 - low CC: david, dcook, jonathan.druart, m.de.rooy, martin.renvoize, nick, tomascohen
Version: Main   
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: Small patch Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
25.11.00
Circulation function:
Bug Depends on:    
Bug Blocks: 25551    
Attachments: Bug 40265: (try to) prevent OAI/Server.t to fail on slow server
Bug 40265: (try to) prevent OAI/Server.t to fail on slow server
Bug 40265: (try to) prevent OAI/Server.t to fail on slow server

Description Lucas Gass (lukeg) 2025-06-27 17:36:51 UTC
-Add something to OPACHiddenItems like withdrawn: [1]
-Have no items in your DB with that value 
-prove -v /kohadevbox/koha/t/db_dependent/OAI/Server.t

Tests fail
Comment 1 David Cook 2025-06-30 00:03:10 UTC
Hmm nope. Seems to work fine for me.
Comment 2 David Nind 2025-06-30 00:46:14 UTC
I couldn't replicate eiterh - the tests passed for me.
Comment 3 Jonathan Druart 2025-07-03 07:07:14 UTC
What was the error?

This one?

21:50:07 koha_1       |     #    got : '2025-06-26T19:50:06Z'
21:50:07 koha_1       |     # expect : '2025-06-26T19:50:07Z'

this is "expected" we should not compare timestamp without using t::lib::Dates::compare
Comment 4 Jonathan Druart 2025-07-03 07:33:41 UTC
Created attachment 183723 [details] [review]
Bug 40265: (try to) prevent OAI/Server.t to fail on slow server

Jenkins failed with:
21:50:07 koha_1       |     #    got : '2025-06-26T19:50:06Z'
21:50:07 koha_1       |     # expect : '2025-06-26T19:50:07Z'

A guess is that we change second between the 2 dt_from_string calls, and
the comparison fails.

One thing however: it seems that we want to deal with timezone correctly
here, but if we change the timezone in koha-conf.xml, the tests fail...
Comment 5 David Nind 2025-07-03 08:32:35 UTC
Created attachment 183725 [details] [review]
Bug 40265: (try to) prevent OAI/Server.t to fail on slow server

Jenkins failed with:
21:50:07 koha_1       |     #    got : '2025-06-26T19:50:06Z'
21:50:07 koha_1       |     # expect : '2025-06-26T19:50:07Z'

A guess is that we change second between the 2 dt_from_string calls, and
the comparison fails.

One thing however: it seems that we want to deal with timezone correctly
here, but if we change the timezone in koha-conf.xml, the tests fail...

Signed-off-by: David Nind <david@davidnind.com>
Comment 6 Marcel de Rooy 2025-08-07 13:03:16 UTC
not ok 34 - Tests for timestamp handling
#   Failed test 'Tests for timestamp handling'
#   at t/db_dependent/OAI/Server.t line 992.
Comment 7 Marcel de Rooy 2025-08-07 13:04:11 UTC
(In reply to Marcel de Rooy from comment #6)
> not ok 34 - Tests for timestamp handling
> #   Failed test 'Tests for timestamp handling'
> #   at t/db_dependent/OAI/Server.t line 992.

Wait. Could be my timezone..
Comment 8 Marcel de Rooy 2025-08-07 13:16:09 UTC
Still failing on Etc/UTC with me
Comment 9 Jonathan Druart 2025-09-01 10:54:04 UTC
This is passing for me on a fresh ktd.

Does it pass on main?
Comment 10 Marcel de Rooy 2025-09-04 09:14:07 UTC
(In reply to Jonathan Druart from comment #9)
> This is passing for me on a fresh ktd.
> 
> Does it pass on main?

Retried on current main. Exported TZ=Etc/UTC and set the same in koha-conf.
Still fails with me.
Comment 11 Marcel de Rooy 2025-09-26 06:19:29 UTC
Created attachment 186953 [details] [review]
Bug 40265: (try to) prevent OAI/Server.t to fail on slow server

Jenkins failed with:
21:50:07 koha_1       |     #    got : '2025-06-26T19:50:06Z'
21:50:07 koha_1       |     # expect : '2025-06-26T19:50:07Z'

A guess is that we change second between the 2 dt_from_string calls, and
the comparison fails.

One thing however: it seems that we want to deal with timezone correctly
here, but if we change the timezone in koha-conf.xml, the tests fail...

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Change looks good, but does not work for another timezone.
Comment 12 Marcel de Rooy 2025-09-26 06:20:04 UTC
See commit message. And comment10 (no response).
Comment 13 Lucas Gass (lukeg) 2025-09-26 16:39:28 UTC
Nice work everyone!

Pushed to main for 25.11