Summary: | t/db_dependent/OAI/Server.t is failing randomly | ||
---|---|---|---|
Product: | Koha | Reporter: | Lucas Gass (lukeg) <lucas> |
Component: | Architecture, internals, and plumbing | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | Pushed to main --- | QA Contact: | Marcel de Rooy <m.de.rooy> |
Severity: | normal | ||
Priority: | P5 - low | CC: | david, dcook, jonathan.druart, m.de.rooy, martin.renvoize, nick, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Small patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: |
25.11.00
|
Circulation function: | |
Bug Depends on: | |||
Bug Blocks: | 25551 | ||
Attachments: |
Bug 40265: (try to) prevent OAI/Server.t to fail on slow server
Bug 40265: (try to) prevent OAI/Server.t to fail on slow server Bug 40265: (try to) prevent OAI/Server.t to fail on slow server |
Description
Lucas Gass (lukeg)
2025-06-27 17:36:51 UTC
Hmm nope. Seems to work fine for me. I couldn't replicate eiterh - the tests passed for me. What was the error? This one? 21:50:07 koha_1 | # got : '2025-06-26T19:50:06Z' 21:50:07 koha_1 | # expect : '2025-06-26T19:50:07Z' this is "expected" we should not compare timestamp without using t::lib::Dates::compare Created attachment 183723 [details] [review] Bug 40265: (try to) prevent OAI/Server.t to fail on slow server Jenkins failed with: 21:50:07 koha_1 | # got : '2025-06-26T19:50:06Z' 21:50:07 koha_1 | # expect : '2025-06-26T19:50:07Z' A guess is that we change second between the 2 dt_from_string calls, and the comparison fails. One thing however: it seems that we want to deal with timezone correctly here, but if we change the timezone in koha-conf.xml, the tests fail... Created attachment 183725 [details] [review] Bug 40265: (try to) prevent OAI/Server.t to fail on slow server Jenkins failed with: 21:50:07 koha_1 | # got : '2025-06-26T19:50:06Z' 21:50:07 koha_1 | # expect : '2025-06-26T19:50:07Z' A guess is that we change second between the 2 dt_from_string calls, and the comparison fails. One thing however: it seems that we want to deal with timezone correctly here, but if we change the timezone in koha-conf.xml, the tests fail... Signed-off-by: David Nind <david@davidnind.com> not ok 34 - Tests for timestamp handling # Failed test 'Tests for timestamp handling' # at t/db_dependent/OAI/Server.t line 992. (In reply to Marcel de Rooy from comment #6) > not ok 34 - Tests for timestamp handling > # Failed test 'Tests for timestamp handling' > # at t/db_dependent/OAI/Server.t line 992. Wait. Could be my timezone.. Still failing on Etc/UTC with me This is passing for me on a fresh ktd. Does it pass on main? (In reply to Jonathan Druart from comment #9) > This is passing for me on a fresh ktd. > > Does it pass on main? Retried on current main. Exported TZ=Etc/UTC and set the same in koha-conf. Still fails with me. Created attachment 186953 [details] [review] Bug 40265: (try to) prevent OAI/Server.t to fail on slow server Jenkins failed with: 21:50:07 koha_1 | # got : '2025-06-26T19:50:06Z' 21:50:07 koha_1 | # expect : '2025-06-26T19:50:07Z' A guess is that we change second between the 2 dt_from_string calls, and the comparison fails. One thing however: it seems that we want to deal with timezone correctly here, but if we change the timezone in koha-conf.xml, the tests fail... Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Change looks good, but does not work for another timezone. See commit message. And comment10 (no response). Nice work everyone! Pushed to main for 25.11 |