Bug 40265

Summary: t/db_dependent/OAI/Server.t is failing randomly
Product: Koha Reporter: Lucas Gass (lukeg) <lucas>
Component: Architecture, internals, and plumbingAssignee: Jonathan Druart <jonathan.druart>
Status: Signed Off --- QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: david, dcook, jonathan.druart, martin.renvoize, nick, tomascohen
Version: Main   
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: --- Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
Circulation function:
Bug Depends on:    
Bug Blocks: 25551    
Attachments: Bug 40265: (try to) prevent OAI/Server.t to fail on slow server
Bug 40265: (try to) prevent OAI/Server.t to fail on slow server

Description Lucas Gass (lukeg) 2025-06-27 17:36:51 UTC
-Add something to OPACHiddenItems like withdrawn: [1]
-Have no items in your DB with that value 
-prove -v /kohadevbox/koha/t/db_dependent/OAI/Server.t

Tests fail
Comment 1 David Cook 2025-06-30 00:03:10 UTC
Hmm nope. Seems to work fine for me.
Comment 2 David Nind 2025-06-30 00:46:14 UTC
I couldn't replicate eiterh - the tests passed for me.
Comment 3 Jonathan Druart 2025-07-03 07:07:14 UTC
What was the error?

This one?

21:50:07 koha_1       |     #    got : '2025-06-26T19:50:06Z'
21:50:07 koha_1       |     # expect : '2025-06-26T19:50:07Z'

this is "expected" we should not compare timestamp without using t::lib::Dates::compare
Comment 4 Jonathan Druart 2025-07-03 07:33:41 UTC
Created attachment 183723 [details] [review]
Bug 40265: (try to) prevent OAI/Server.t to fail on slow server

Jenkins failed with:
21:50:07 koha_1       |     #    got : '2025-06-26T19:50:06Z'
21:50:07 koha_1       |     # expect : '2025-06-26T19:50:07Z'

A guess is that we change second between the 2 dt_from_string calls, and
the comparison fails.

One thing however: it seems that we want to deal with timezone correctly
here, but if we change the timezone in koha-conf.xml, the tests fail...
Comment 5 David Nind 2025-07-03 08:32:35 UTC
Created attachment 183725 [details] [review]
Bug 40265: (try to) prevent OAI/Server.t to fail on slow server

Jenkins failed with:
21:50:07 koha_1       |     #    got : '2025-06-26T19:50:06Z'
21:50:07 koha_1       |     # expect : '2025-06-26T19:50:07Z'

A guess is that we change second between the 2 dt_from_string calls, and
the comparison fails.

One thing however: it seems that we want to deal with timezone correctly
here, but if we change the timezone in koha-conf.xml, the tests fail...

Signed-off-by: David Nind <david@davidnind.com>