Summary: | Patron attribute types cannot be made mandatory | ||
---|---|---|---|
Product: | Koha | Reporter: | Cindy Murdock Ames <cmurdock> |
Component: | Patrons | Assignee: | Kyle M Hall <kyle.m.hall> |
Status: | RESOLVED DUPLICATE | QA Contact: | Bugs List <koha-bugs> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | andrew, barton, cbrannon, chris, fiona.borthwick, janet.mcgowan, jzairo, kyle.m.hall, lisettepalouse+koha, marjorie.barry-vila, patrick.robitaille |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22728 | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: | This patch adds the ability to make a patron attribute type mandatory. |
Description
Chris Cormack
2010-05-21 01:22:19 UTC
Needs a new patch, this contains HTML::Template::Pro templates This looks like it would be useful to pick up again. Is there a problem with it besides the template issue? *** Bug 4418 has been marked as a duplicate of this bug. *** *** Bug 20288 has been marked as a duplicate of this bug. *** I looked at the patch, I think it's a lot more complicated than it needs to be. Right now, Each of the borrower attribute select statements generated by memberentrygen.tt looks like this: <select id="patron_attr_1" name="patron_attr_1" class="noEnterSubmit"> ... The id for the second is patron_attr_2, etc. If we change this to use values from borrower_attribute_types.category_code as the ID, I believe that we can then simply use these category codes in BorrowerMandatoryField. Poking this old bug again. It is currently *possible* to make patron attributes mandatory by referring to them as patron_attr_1, patron_attr_2, etc, but those labels are relative to their position when listed on memberentry, so the numbers change when attributes are added or removed, requiring an adjustment to BorrowerMandatoryField. This is workable but clunky and requires extra work. If possible, I'd support the suggestion of marking BorrowerMandatoryField use the codes for each attribute. *** Bug 13366 has been marked as a duplicate of this bug. *** Our customers often require patron attributes to be mandatory so +1 for enhancing the borrowermandatoryfield system preference. +1 +1 |