| 
        
          Description
        
        
          Donna
        
        
        
        
          2025-07-09 21:02:12 UTC
        
       Created attachment 183908 [details] [review] Bug 40335: Add ability to multi select collections and locations for holds queue To test: 0. APPLY PATCH and restart_all 1. Place some holds with different shelving locations and collection codes. 2. Build the holds queue 3. Go to Circulation > Holds queue 4. Notice that shelfing location and collection code are now multi select2 dropdowns 5. Try searching for various combos of shelfing locations and collection codes. 6. Make sure the results are correct. 7. After making selections and running the search make sure your selections are retained in the search form in the left nav bar Created attachment 183909 [details] [review] Bug 40335: Add ability to multi select collections and locations for holds queue To test: 0. APPLY PATCH and restart_all 1. Place some holds with different shelving locations and collection codes. 2. Build the holds queue 3. Go to Circulation > Holds queue 4. Notice that shelfing location and collection code are now multi select2 dropdowns 5. Try searching for various combos of shelfing locations and collection codes. 6. Make sure the results are correct. 7. After making selections and running the search make sure your selections are retained in the search form in the left nav bar I only did the collection and shelving location dropdowns because that is what was reported. I was not sure about branches or item types. Also, if you make no selection for shelf locations or collection codes it is the same as doing a search on 'All'. Should we add a hint about that below the selection box? Created attachment 183911 [details] [review] Bug 40335: Add ability to multi select collections and locations for holds queue To test: 0. APPLY PATCH and restart_all 1. Place some holds with different shelving locations and collection codes. 2. Build the holds queue 3. Go to Circulation > Holds queue 4. Notice that shelfing location and collection code are now multi select2 dropdowns 5. Try searching for various combos of shelfing locations and collection codes. 6. Make sure the results are correct. 7. After making selections and running the search make sure your selections are retained in the search form in the left nav bar Created attachment 183912 [details] [review] Bug 40335: Fix mistake in template params Created attachment 183913 [details] [review] Bug 40335: Fix mistake in template params Once I've used the multi-select to limit by ccode and/or shelving location, if I clear those filters and click Submit again without first reloading the page I get an erroneous NULL search result. On second look, I cannot recreate this issue. Setting back to NSO. Created attachment 184460 [details] [review] Bug 40335: Fix mistake in template params Signed-off-by: David Flater <flaterdavid@gmail.com> Created attachment 184480 [details] [review] Bug 40335: Add ability to multi select collections and locations for holds queue To test: 0. APPLY PATCH and restart_all 1. Place some holds with different shelving locations and collection codes. 2. Build the holds queue 3. Go to Circulation > Holds queue 4. Notice that shelfing location and collection code are now multi select2 dropdowns 5. Try searching for various combos of shelfing locations and collection codes. 6. Make sure the results are correct. 7. After making selections and running the search make sure your selections are retained in the search form in the left nav bar Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 184481 [details] [review] Bug 40335: Fix mistake in template params Signed-off-by: David Flater <flaterdavid@gmail.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 184482 [details] [review] Bug 40335: (follow-up) Fix style of Select2 in sidebar This patch adjusts the style of the Select2 field in the sidebar. It should have 100% width and the selections should word-wrap. Created attachment 186904 [details] [review] Wonderful job on this patch! Thank you! Bug 40335: Add ability to multi select collections and locations for holds queue To test: 0. APPLY PATCH and restart_all 1. Place some holds with different shelving locations and collection codes. 2. Build the holds queue 3. Go to Circulation > Holds queue 4. Notice that shelfing location and collection code are now multi select2 dropdowns 5. Try searching for various combos of shelfing locations and collection codes. 6. Make sure the results are correct. 7. After making selections and running the search make sure your selections are retained in the search form in the left nav bar Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> Created attachment 186905 [details] [review] Bug 40335: Fix mistake in template params Signed-off-by: David Flater <flaterdavid@gmail.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> Created attachment 186906 [details] [review] Bug 40335: (follow-up) Fix style of Select2 in sidebar This patch adjusts the style of the Select2 field in the sidebar. It should have 100% width and the selections should word-wrap. Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> Created attachment 186988 [details] [review] Bug 40335: Add ability to multi select collections and locations for holds queue To test: 0. APPLY PATCH and restart_all 1. Place some holds with different shelving locations and collection codes. 2. Build the holds queue 3. Go to Circulation > Holds queue 4. Notice that shelfing location and collection code are now multi select2 dropdowns 5. Try searching for various combos of shelfing locations and collection codes. 6. Make sure the results are correct. 7. After making selections and running the search make sure your selections are retained in the search form in the left nav bar Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> Created attachment 186989 [details] [review] Bug 40335: Fix mistake in template params Signed-off-by: David Flater <flaterdavid@gmail.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> Created attachment 186991 [details] [review] Bug 40335: (follow-up) Fix style of Select2 in sidebar This patch adjusts the style of the Select2 field in the sidebar. It should have 100% width and the selections should word-wrap. Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> Nice work everyone! Pushed to main for 25.11 |