Summary: | xt/find-license-problems.t isn't catching all instances of 51 Franklin St/Street | ||
---|---|---|---|
Product: | Koha | Reporter: | Lucas Gass (lukeg) <lucas> |
Component: | Test Suite | Assignee: | Tomás Cohen Arazi (tcohen) <tomascohen> |
Status: | Pushed to stable --- | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | jonathan.druart, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: |
25.11.00,25.05.02
|
Circulation function: | |
Bug Depends on: | 40402 | ||
Bug Blocks: | |||
Attachments: |
Bug 40419: Remove check for Copyright line
Bug 40419: Skip testing-related templates Bug 40419: Fix wrong license Bug 40419: Changes to testing logic Bug 40419: Fix wrong license Bug 40419: Changes to testing logic Bug 40419: Fix wrong license |
Description
Lucas Gass (lukeg)
2025-07-16 16:54:36 UTC
Created attachment 184164 [details] [review] Bug 40419: Remove check for Copyright line The Copyright line should not be mandatory. And if missing, is not a reason to skip the GPL-related checks anyway. This 'fix' will highlight existing errors that were skipped until now. To test: 1. Run: $ ktd --shell k$ prove xt/find-license-problems.t => FAIL: Tests pass! Some files should make them fail! 2. Apply this patch 3. Repeat 1 => SUCCESS: Tests fail! Created attachment 184165 [details] [review] Bug 40419: Skip testing-related templates Created attachment 184166 [details] [review] Bug 40419: Fix wrong license The correct fix is on bug 40402, I told you on mattermost ;-) *** This bug has been marked as a duplicate of bug 40402 *** Or maybe it's actually related and not duplicated. But bug 40402 is going to fix Jenkins the correct way. If we need more it should be written on top of it. Created attachment 184175 [details] [review] Bug 40419: Changes to testing logic This patch makes a couple changes to the tests: * Remove check for Copyright line. The Copyright line should not be mandatory. * Remove dependency of GPL-related checks on the copyrigth line existence. (this highlights several missed checks). * Skip testing-related templates. Koha ships some templates that are not excluded correctly. This 'fix' will highlight existing errors that were skipped until now. To test: 1. Run: $ ktd --shell k$ prove xt/find-license-problems.t => FAIL: Tests pass! Some files should make them fail! 2. Apply this patch 3. Repeat 1 => SUCCESS: Tests fail! Created attachment 184176 [details] [review] Bug 40419: Fix wrong license Lucas: * I think errors in the external libs we include should better be reported upstream. `koha-tmpl/` is explicitly excluded so I wouldn't care. * I don't think the Copyright line check makes sense. Right now it is only being used to skip the GPL check which is incorrect. ... I mistakenly submitted before finishing. That's why I propose to remove the copyright line check. Nice catch! I believe I covered them all. Created attachment 184182 [details] [review] Bug 40419: Changes to testing logic This patch makes a couple changes to the tests: * Remove check for Copyright line. The Copyright line should not be mandatory. * Remove dependency of GPL-related checks on the copyrigth line existence. (this highlights several missed checks). * Skip testing-related templates. Koha ships some templates that are not excluded correctly. This 'fix' will highlight existing errors that were skipped until now. To test: 1. Run: $ ktd --shell k$ prove xt/find-license-problems.t => FAIL: Tests pass! Some files should make them fail! 2. Apply this patch 3. Repeat 1 => SUCCESS: Tests fail! Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 184183 [details] [review] Bug 40419: Fix wrong license Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Nice work everyone! Pushed to main for 25.11 Nice work everyone! Pushed to 25.05.x |