Summary: | Wherever possible we should lookup using borrowernumber instead of userid/cardnumber | ||
---|---|---|---|
Product: | Koha | Reporter: | David Cook <dcook> |
Component: | Architecture, internals, and plumbing | Assignee: | Bugs List <koha-bugs> |
Status: | NEW --- | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | ||
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40275 | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Bug Depends on: | 13542, 34018, 39535, 40456, 40464 | ||
Bug Blocks: |
Description
David Cook
2025-07-21 03:53:47 UTC
After applying 40275 I notice there's still a lot of times where we lookup borrowers using cardnumber. grep -R --exclude-dir="node_modules" --exclude-dir="t" --exclude-dir=".git" -- "->find.*cardnumber" | wc -l This returns 27 occurrences. Some of these will be legitimate but we've got lots of weird ones like reserve/request.pl where we use the cardnumber in koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt instead of the borrowernumber koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt is an interesting one. There we use circulation.pl?findborrower with a cardnumber... and that is probably OK because the data at hand is the cardnumber. -- Anyway, this will take some investigating and teasing apart overall. Best to do in other dependence reports I think. |