Summary: | Subfields names in control fields should not be displayed/editable | ||
---|---|---|---|
Product: | Koha | Reporter: | Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski> |
Component: | Cataloging | Assignee: | Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski> |
Status: | Needs Signoff --- | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | m.de.rooy |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: | Bug 40556 - Subfields names in control fields should not be displayed/editable |
Description
Baptiste Wojtkowski (bwoj)
2025-07-30 15:08:05 UTC
Created attachment 184899 [details] [review] Bug 40556 - Subfields names in control fields should not be displayed/editable In cataloguing/addbiblio.pl, there is a conditionnal display of the subfield name field. However, it is depending on subfield_loo.fixedfield, which is never set up. However, the field corresponding information is available in innerloo.fixedfield. <input type="text" title="[% subfield_loo.marc_lib | $raw %]" style=" [% IF ( subfield_loo.fixedfield ) %]display:none; [% END %]" name="tag_[% subfield_loo.tag | html %]_code_[% subfield_loo.subfield | html %]_[% subfield_loo.index | html %]_[% subfield_loo.index_subfield | html %]" value="[% subfield_loo.subfield | html %]" size="1" Moreover, following code does not make sense for control fields: <span class="handle"></span> TEST PLAN: 1 - Edit any record. Note that you can grab subfields, note you can edit the 00 in the subfield input 2 - Apply patch 3 - On the same page, you should not be able to grab or edit subfield titles. |