| Summary: | Various corrections to recalls templates | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Owen Leonard <oleonard> |
| Component: | Templates | Assignee: | Owen Leonard <oleonard> |
| Status: | Signed Off --- | QA Contact: | Testopia <testopia> |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | david |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: |
This makes some minor changes to recalls templates:
- Fixes the date sorting on the recalls queue page
- Hides "Show old recalls" if there are no recalls in a patron's recalls history, and adds the "page-section" div (white background)
|
Version(s) released in: | |
| Circulation function: | |||
| Bug Depends on: | 40560, 40566 | ||
| Bug Blocks: | 40589 | ||
| Attachments: |
Bug 40568: Various corrections to recalls templates
Bug 40568: Various corrections to recalls templates Bug 40568: Various corrections to recalls templates |
||
|
Description
Owen Leonard
2025-07-31 16:46:09 UTC
Created attachment 184937 [details] [review] Bug 40568: Various corrections to recalls templates This patch makes various minor changes to recalls templates. - Correct markup in dropdown menu - Correct sorting of dates in tables - Wrap recalls table in "page-section" div. - Hide "Show old recalls" if there are no recalls. To test, apply the patch and enable Recalls if necessary. - If necessary, place some recalls. - Go to Circulation -> Recalls queue and check the "Actions" menu for one of the recalls. The "Mark as overdue" menu item should be formatted correctly. - Check the sorting of date columns on the "Recalls queue" page. It should be correct. - View a patron who has never placed a recall. Go to their recalls history and confirm that you see a "Patron has no recalls" message but no "Show old recalls" checkbox. Sponsored-by: Athens County Public Libraries The patch still applies, however: 1. I have no idea on the SQL required to make a recall overdue so that the "Mark as overdue" menu item is shown. 2. For sorting of date columns on the "Recalls queue" page, it seems to work OK before the patch--so I'm not sure how to reproduce that it is not working. (Example SQL to update the created date: update recalls set created_date = "2025-11-07 00:00:00" where recall_id=1 The patch no longer applies 8-(... git bz apply 40568 Bug 40568 - Various corrections to recalls templates 184937 - Bug 40568: Various corrections to recalls templates Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 40568: Various corrections to recalls templates Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/en/includes/recalls.inc Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/includes/recalls.inc CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/includes/recalls.inc error: Failed to merge in the changes. Patch failed at 0001 Bug 40568: Various corrections to recalls templates Created attachment 190902 [details] [review] Bug 40568: Various corrections to recalls templates This patch makes various minor changes to recalls templates. - Correct sorting of dates in tables - Wrap recalls table in "page-section" div. - Hide "Show old recalls" if there are no recalls. To test, apply the patch and enable Recalls if necessary. - If necessary, place some recalls. - Check the sorting of date columns on the "Recalls queue" page. It should be correct. - View a patron who has never placed a recall. Go to their recalls history and confirm that you see a "Patron has no recalls" message but no "Show old recalls" checkbox. Sponsored-by: Athens County Public Libraries Created attachment 190913 [details] [review] Bug 40568: Various corrections to recalls templates This patch makes various minor changes to recalls templates. - Correct sorting of dates in tables - Wrap recalls table in "page-section" div. - Hide "Show old recalls" if there are no recalls. To test, apply the patch and enable Recalls if necessary. - If necessary, place some recalls. - Check the sorting of date columns on the "Recalls queue" page. It should be correct. - View a patron who has never placed a recall. Go to their recalls history and confirm that you see a "Patron has no recalls" message but no "Show old recalls" checkbox. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> |