Bug 40593

Summary: Can't search all columns in Acquisitions Suggestions table
Product: Koha Reporter: Aude Charillon <aude.charillon>
Component: AcquisitionsAssignee: Matt Blenkinsop <matt.blenkinsop>
Status: Pushed to main --- QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: Laura.escamilla, lucas, ludovic.julien, martin.renvoize, mirjam.vantieghem
Version: MainKeywords: rel_25_05_candidate, release-notes-needed
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: --- Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
25.11.00
Circulation function:
Attachments: Bug 40593: Restore searchable columns to the suggestions table
Bug 40593: Restore searchable columns to the suggestions table
Works great! QA tool is also happy. Thanks!
Bug 40593: Restore searchable columns to the suggestions table

Description Aude Charillon 2025-08-05 10:33:13 UTC
The search box above the table in Acquisitions > Suggestions seems to be broken in 24.11.06. I was able to test in 24.11.03 and it is working correctly in that version.

To replicate:
- Make sure you have suggestions.
- In any of the tabs with suggestions listed, use the Search box above the table.
- Search for words that you see in either the Suggestion or Suggested by column: the list is correctly filtered to those lines.
- Search for words contained in any other column, e.g. Library. No results are shown, even though there should be.

Note: Library is not one of the parameters available in the left-hand Filters menu, so there is no workaround to this issue when you need to check suggestions within a status tab then filter down by library.
Comment 1 Owen Leonard 2025-08-05 14:10:24 UTC
Looks like the table has been configured to allow searching only on title, suggester, manager, or last modifier. I'm not sure why those limitations were chosen.
Comment 2 Matt Blenkinsop 2025-08-19 09:31:02 UTC
Created attachment 185536 [details] [review]
Bug 40593: Restore searchable columns to the suggestions table

This patch adds search functionality to the following columns: Suggester category, Patron reason, Library, Fund, Status.

Test plan:
1) Add some suggestions and navigate to the suggestions page
2) Use the search bar to search for data in any of the columns mentioned above.
3) It will not filter the results based on those columns
4) Apply patch and hard refresh
5) Use the search bar again, this time it should return results
Comment 3 Mirjam Vantieghem 2025-08-21 09:08:04 UTC
Could the patch be altered to also restore the search filter on author, ISBN, publisher, copyright date, collection title, and notes (basically everything that comes after the 'title' in the 'Suggestion' column)? It used to be searchable in previous versions and is also important.

Except for the notes, there are all parameters in the left-hand Filter menu, but it is much faster and more convenient to use the search filter on top, like before.
Comment 4 Ludovic 2025-09-05 20:28:21 UTC
Created attachment 186249 [details] [review]
Bug 40593: Restore searchable columns to the suggestions table

This patch adds search functionality to the following columns: Suggester category, Patron reason, Library, Fund, Status.

Test plan:
1) Add some suggestions and navigate to the suggestions page
2) Use the search bar to search for data in any of the columns mentioned above.
3) It will not filter the results based on those columns
4) Apply patch and hard refresh
5) Use the search bar again, this time it should return results

Signed-off-by: Ludovic <ludovic.julien@inlibro.com>
Comment 5 Ludovic 2025-09-05 20:31:12 UTC
Great work on this patch!
I tested it and everything works perfectly. Being able to search all relevant columns in the suggestions table is a major usability improvement — especially for libraries managing large volumes of suggestions.

Thank you for restoring this functionality!
It really helps staff work more efficiently.

Signed off! :)
Comment 6 Laura Escamilla 2025-09-24 15:40:27 UTC
(In reply to Mirjam Vantieghem from comment #3)

I recommend opening a new bug for these search filters.
Comment 7 Laura Escamilla 2025-09-24 15:42:35 UTC
Created attachment 186896 [details] [review]
Works great! QA tool is also happy. Thanks!

Bug 40593: Restore searchable columns to the suggestions table

This patch adds search functionality to the following columns: Suggester category, Patron reason, Library, Fund, Status.

Test plan:
1) Add some suggestions and navigate to the suggestions page
2) Use the search bar to search for data in any of the columns mentioned above.
3) It will not filter the results based on those columns
4) Apply patch and hard refresh
5) Use the search bar again, this time it should return results

Signed-off-by: Ludovic <ludovic.julien@inlibro.com>
Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com>
Comment 8 Laura Escamilla 2025-09-26 16:36:46 UTC
Created attachment 186987 [details] [review]
Bug 40593: Restore searchable columns to the suggestions table

This patch adds search functionality to the following columns: Suggester category, Patron reason, Library, Fund, Status.

Test plan:
1) Add some suggestions and navigate to the suggestions page
2) Use the search bar to search for data in any of the columns mentioned above.
3) It will not filter the results based on those columns
4) Apply patch and hard refresh
5) Use the search bar again, this time it should return results

Signed-off-by: Ludovic <ludovic.julien@inlibro.com>
Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com>
Comment 9 Lucas Gass (lukeg) 2025-09-26 16:40:24 UTC
Nice work everyone!

Pushed to main for 25.11