| Summary: | Patron.pm can create warnings | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Lucas Gass (lukeg) <lucas> |
| Component: | Architecture, internals, and plumbing | Assignee: | Lucas Gass (lukeg) <lucas> |
| Status: | RESOLVED FIXED | QA Contact: | Tomás Cohen Arazi (tcohen) <tomascohen> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | david, fridolin.somers, tomascohen |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
25.11.00,25.05.04
|
|
| Circulation function: | |||
| Bug Depends on: | 22632 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 40641: Fallback to empty values when logging action
Bug 40641: Fallback to empty values when logging action Bug 40641: Fallback to empty values when logging action |
||
|
Description
Lucas Gass (lukeg)
2025-08-12 21:52:10 UTC
Created attachment 185356 [details] [review] Bug 40641: Fallback to empty values when logging action Created attachment 185372 [details] [review] Bug 40641: Fallback to empty values when logging action Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Trivial patch and the obvious cause of the regression, self sign-off. Created attachment 185373 [details] [review] Bug 40641: Fallback to empty values when logging action Bug 22632 introduced the merge logging feature but missed to sanitize strings to avoid warnings. This patch fixes that. To test: 1. Run: $ ktd --shell k$ prove t/db_dependent/Patron/Borrower_Debarments.t => FAIL: Tests fail! Warnings introduced! 2. Apply this patch 3. Repeat 1 => SUCCESS: Tests pass! 4. Sign off :-D Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Pushed to main for 25.11.x, thanks all. Nice work everyone! Pushed to 25.05.x No changes to the manual required. |