Summary: | Koha::ILL::Request->status inconsistencies | ||
---|---|---|---|
Product: | Koha | Reporter: | Tomás Cohen Arazi (tcohen) <tomascohen> |
Component: | ILL | Assignee: | Tomás Cohen Arazi (tcohen) <tomascohen> |
Status: | ASSIGNED --- | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | lisette, pedro.amorim, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: |
Description
Tomás Cohen Arazi (tcohen)
2025-08-20 19:36:40 UTC
I would like to add that the method itself does: * log status changes * deal with status_alias undefinition This means those features will only be used if ->status is used exclusively when changing statuses. This means an author using: ```perl $req->set( { status => 'NEW_STATUS', due_date => dt_from_string() } )->store(); ``` won't get the expected results. We need to either: * Document statuses should never be done using ->set or ->update (including the resultset method) * Move all this to the store() level I also noticed the trick for nullifying the status_alias is also a consequence of how accessors are used in this module. This all needs a rethink. |