Summary: | Permission error for vendors if user has not full acquisition module permission | ||
---|---|---|---|
Product: | Koha | Reporter: | Michaela Sieber <michaela.sieber> |
Component: | Acquisitions | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | Pushed to stable --- | QA Contact: | Matt Blenkinsop <matt.blenkinsop> |
Severity: | major | ||
Priority: | P5 - low | CC: | caroline.cyr-la-rose, cbrannon, Chip.Halvorsen, jonathan.druart, katrin.fischer, lucas, matt.blenkinsop, mspinney, nick, paul.derscheid, rcoert |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38446 | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: |
25.11.00,25.05.04
|
Circulation function: | |
Bug Depends on: | 38010 | ||
Bug Blocks: | 40868 | ||
Attachments: |
Bug 40684: Adjust permissions for vendors
Bug 40684: Adjust permissions for vendors Bug 40684: Adjust permissions for vendors |
Description
Michaela Sieber
2025-08-21 15:53:43 UTC
I think this is major as it could be a very big issue for libraries that don't want to give the _all permissions in a consortial setting. But also if someone only needs vendors for working with the serials or ERM module. Updating severity. Created attachment 186027 [details] [review] Bug 40684: Adjust permissions for vendors The acquisition config route should be accessible to users with at least one acquisition subpermission or erm permission. The list vendors route should be accessible to users with the erm permission. This patch fixed the original problem, but there are more to fix it seems. the erm module is still not loading properly (I guess it can be fixed later). How do you feel about this patch, Matt? Created attachment 186889 [details] [review] Bug 40684: Adjust permissions for vendors The acquisition config route should be accessible to users with at least one acquisition subpermission or erm permission. The list vendors route should be accessible to users with the erm permission. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Created attachment 186891 [details] [review] Bug 40684: Adjust permissions for vendors The acquisition config route should be accessible to users with at least one acquisition subpermission or erm permission. The list vendors route should be accessible to users with the erm permission. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> I think this is the best solution for now, PQA Nice work everyone! Pushed to main for 25.11 Can this be back ported to 25.05? (In reply to Christopher Brannon from comment #8) > Can this be back ported to 25.05? I second this request. Thank you for considering! +1 Katrin's comment re: issue severity for consortial settings +1 on the backporting request Nice work everyone! Pushed to 25.05.x |