| Summary: | Checkout status doesn't appear on moredetail.pl if item is not checked out | ||
|---|---|---|---|
| Product: | Koha | Reporter: | David Cook <dcook> |
| Component: | Circulation | Assignee: | David Cook <dcook> |
| Status: | Pushed to oldstable --- | QA Contact: | Marcel de Rooy <m.de.rooy> |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | anneli.osterman, fridolin.somers, gmcharlt, kyle, m.de.rooy |
| Version: | Main | Keywords: | Academy |
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
25.11.00,25.05.04,24.11.10
|
|
| Circulation function: | |||
| Attachments: |
Bug 40690: Fix if/else/end logic for checkout
Bug 40690: Fix if/else/end logic for checkout Bug 40690: Fix if/else/end logic for checkout |
||
|
Description
David Cook
2025-08-22 06:19:58 UTC
Created attachment 185705 [details] [review] Bug 40690: Fix if/else/end logic for checkout This change fixes the Checkout status on moredetail.pl so that it actually shows "Not checked out" when it's not checked out. Test plan: 0. Apply the patch 1. Go to /cgi-bin/koha/catalogue/moredetail.pl?biblionumber=29 on a fresh KTD 2. Note that the "Checkout status" is "Not checked out" 3. Check out the item to someone 4. Go to /cgi-bin/koha/catalogue/moredetail.pl?biblionumber=29 5. Note that it says "Checked out to <person> Due back on <date>" 6. Renew the item 7. Go to /cgi-bin/koha/catalogue/moredetail.pl?biblionumber=29 8. Note that it says "Checked out to <person> Last renewed <date>, Due back on <date>" Created attachment 185727 [details] [review] Bug 40690: Fix if/else/end logic for checkout This change fixes the Checkout status on moredetail.pl so that it actually shows "Not checked out" when it's not checked out. Test plan: 0. Apply the patch 1. Go to /cgi-bin/koha/catalogue/moredetail.pl?biblionumber=29 on a fresh KTD 2. Note that the "Checkout status" is "Not checked out" 3. Check out the item to someone 4. Go to /cgi-bin/koha/catalogue/moredetail.pl?biblionumber=29 5. Note that it says "Checked out to <person> Due back on <date>" 6. Renew the item 7. Go to /cgi-bin/koha/catalogue/moredetail.pl?biblionumber=29 8. Note that it says "Checked out to <person> Last renewed <date>, Due back on <date>" Signed-off-by: Anneli Österman <anneli.osterman@koha-suomi.fi> [% IF ( checkout.date_due ) %]
<span>Due back on [% checkout.date_due | $KohaDates as_due_date => 1 %]</span>
[% END %]
Makes me wonder if you could checkout without a due date ;)
Created attachment 185873 [details] [review] Bug 40690: Fix if/else/end logic for checkout This change fixes the Checkout status on moredetail.pl so that it actually shows "Not checked out" when it's not checked out. Test plan: 0. Apply the patch 1. Go to /cgi-bin/koha/catalogue/moredetail.pl?biblionumber=29 on a fresh KTD 2. Note that the "Checkout status" is "Not checked out" 3. Check out the item to someone 4. Go to /cgi-bin/koha/catalogue/moredetail.pl?biblionumber=29 5. Note that it says "Checked out to <person> Due back on <date>" 6. Renew the item 7. Go to /cgi-bin/koha/catalogue/moredetail.pl?biblionumber=29 8. Note that it says "Checked out to <person> Last renewed <date>, Due back on <date>" Signed-off-by: Anneli Österman <anneli.osterman@koha-suomi.fi> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Nice work everyone! Pushed to main for 25.11 Nice work everyone! Pushed to 25.05.x Pushed to 24.11.x for 24.11.10 |