Bug 40690

Summary: Checkout status doesn't appear on moredetail.pl if item is not checked out
Product: Koha Reporter: David Cook <dcook>
Component: CirculationAssignee: David Cook <dcook>
Status: Needs Signoff --- QA Contact: Testopia <testopia>
Severity: minor    
Priority: P5 - low CC: gmcharlt, kyle
Version: MainKeywords: Academy
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: --- Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
Circulation function:
Attachments: Bug 40690: Fix if/else/end logic for checkout

Description David Cook 2025-08-22 06:19:58 UTC
If you go to /cgi-bin/koha/catalogue/moredetail.pl?biblionumber=29 on a fresh KTD, you'll see that there is a blank next to "Checkout status:". 

This might not seem weird at first, until you notice that moredetail.tt actually has some HTML that you think would apply in this scenario: <span>Not checked out</span>

If you look at the template, you quickly see there's clearly a bug there.
Comment 1 David Cook 2025-08-22 06:27:00 UTC
Created attachment 185705 [details] [review]
Bug 40690: Fix if/else/end logic for checkout

This change fixes the Checkout status on moredetail.pl so that it
actually shows "Not checked out" when it's not checked out.

Test plan:
0. Apply the patch
1. Go to /cgi-bin/koha/catalogue/moredetail.pl?biblionumber=29 on a fresh KTD
2. Note that the "Checkout status" is "Not checked out"
3. Check out the item to someone
4. Go to /cgi-bin/koha/catalogue/moredetail.pl?biblionumber=29
5. Note that it says "Checked out to <person> Due back on <date>"
6. Renew the item
7. Go to /cgi-bin/koha/catalogue/moredetail.pl?biblionumber=29
8. Note that it says "Checked out to <person> Last renewed <date>, Due back on <date>"