Bug 40692

Summary: Wrong color background in Perl modules page
Product: Koha Reporter: Adolfo Rodríguez Taboada <adolfo.rodriguez>
Component: AboutAssignee: Adolfo Rodríguez Taboada <adolfo.rodriguez>
Status: Needs documenting --- QA Contact: Marcel de Rooy <m.de.rooy>
Severity: trivial    
Priority: P5 - low CC: fridolin.somers, lucas, martin.renvoize
Version: Main   
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: Trivial patch Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
25.11.00,25.05.04
Circulation function:
Bug Depends on: 38714    
Bug Blocks:    
Attachments: Bug 40692 - Wrong color background in Perl modules page This patch fixes the background color of the Perl modules when there are current modules after missing or in need of updgrade modules
Bug 40692 - Wrong color background in Perl modules page This patch fixes the background color of the Perl modules when there are current modules after missing or in need of updgrade modules
Bug 40692: Wrong color background in Perl modules page

Description Adolfo Rodríguez Taboada 2025-08-22 11:00:07 UTC
Page About Koha, tab Perl Modules

When a Perl module is missing or requires an update, Koha sets a background color, but when the module is OK (current) it doesn't reset the background color, so it will keep the background color from the previous checked module. This can make the page very confusing as Perl modules that are current will appear to be missing or need of an upgrade according to the background color but the title will give the correct information.
Comment 1 Adolfo Rodríguez Taboada 2025-08-22 11:02:27 UTC
Created attachment 185708 [details] [review]
Bug 40692 - Wrong color background in Perl modules page This patch fixes the background color of the Perl modules when there are current modules after missing or in need of updgrade modules

1 You need to have in your installation of Koha a missing or in need of updgrade Perl module. Check in the About page Perl Modules Tab that perl modules after it that are current have the same background color that the missing/in need of upgrade
2 Apply patch, restart services
3 Repeat the first step. Now all the current modules have the right background color
Comment 2 Marcel de Rooy 2025-09-04 06:57:26 UTC
Created attachment 186112 [details] [review]
Bug 40692 - Wrong color background in Perl modules page This patch fixes the background color of the Perl modules when there are current modules after missing or in need of updgrade modules

1 You need to have in your installation of Koha a missing or in need of updgrade Perl module. Check in the About page Perl Modules Tab that perl modules after it that are current have the same background color that the missing/in need of upgrade
2 Apply patch, restart services
3 Repeat the first step. Now all the current modules have the right background color

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 3 Marcel de Rooy 2025-09-04 06:58:01 UTC
PQA in one go
Comment 4 Marcel de Rooy 2025-09-04 07:24:12 UTC
Created attachment 186113 [details] [review]
Bug 40692:  Wrong color background in Perl modules page

This patch fixes the background color of the Perl modules when there are current modules after missing or in need of updgrade modules

1 You need to have in your installation of Koha a missing or in need of updgrade Perl module. Check in the About page Perl Modules Tab that perl modules after it that are current have the same background color that the missing/in need of upgrade
2 Apply patch, restart services
3 Repeat the first step. Now all the current modules have the right background color

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 5 Fridolin Somers 2025-09-05 12:58:50 UTC
First attachment need to be obsoleted no ?
Comment 6 Lucas Gass (lukeg) 2025-09-05 13:39:51 UTC
(In reply to Fridolin Somers from comment #5)
> First attachment need to be obsoleted no ?

I'm taking the 2nd patch only for main, they appear to be exactly the same.
Comment 7 Lucas Gass (lukeg) 2025-09-05 14:07:08 UTC
Nice work everyone!

Pushed to main for 25.11
Comment 8 Paul Derscheid 2025-09-20 08:59:32 UTC
Nice work everyone!

Pushed to 25.05.x
Comment 9 Fridolin Somers 2025-10-10 14:50:21 UTC
Depends on Bug 38714 not in 24.11.x