Bug 40701

Summary: Message "Checkouts are BLOCKED because fine balance is OVER THE LIMIT." doesn't display anymore
Product: Koha Reporter: Caroline Cyr La Rose <caroline.cyr-la-rose>
Component: Fines and feesAssignee: Bugs List <koha-bugs>
Status: NEW --- QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low    
Version: Main   
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: --- Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
Circulation function:
Bug Depends on: 28924    
Bug Blocks:    

Description Caroline Cyr La Rose 2025-08-25 16:53:06 UTC
I was trying to get the message "Checkouts are BLOCKED because fine balance is OVER THE LIMIT." to appear in main because I wanted to change it to "charge balance" or simply "balance" instead of "fine balance" (I got a comment from a confused client on 24.05 whose library doesn't charge fines...). It seems, this message doesn't appear anymore in main? It's still in the .inc though.

To recreate:
1. Go to a patron account > Accounting > Create manual invoice
2. Add a Manual fee charge of 100 and click Save
3. Go to Details
   --> There is a message about the fee, but it doesn't say "Checkouts are BLOCKED because fine balance is OVER THE LIMIT."
4. Go to Checkouts
   -- Same.

I feel like it's an unintended change in behaviour brought by bug 28924, maybe? The IF right above the message was changed and I think that's what prevents the message from displaying, but I'm not sure enough to fix it myself.
Comment 1 Caroline Cyr La Rose 2025-08-25 16:54:56 UTC
(TBH, I felt this message was a bit over the top with the capital letters, it's like it's screaming at you. I don't mind that it's not there anymore, but I don't think its removal was intentional...)