Bug 40772

Summary: Title says "Issuing to {user}"
Product: Koha Reporter: Wainui Witika-Park <wainuiwitikapark>
Component: CirculationAssignee: Bugs List <koha-bugs>
Status: RESOLVED INVALID QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: dcook, gmcharlt, kyle, wainuiwitikapark
Version: 25.05   
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: --- Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
Circulation function:
Attachments: the title (tab) says "Issuing to {user}" instead of the user's name

Description Wainui Witika-Park 2025-09-09 01:17:21 UTC
Created attachment 186270 [details]
the title (tab) says "Issuing to {user}" instead of the user's name

When issuing to a user in the staff client, the title (tab) says "Issuing to {user}" instead of the user's name
Comment 1 David Cook 2025-09-09 03:49:00 UTC
I think "Issuing" is a en-NZ localisation as the core code uses "Checking out".

When I grep "Checking out to", I see the following:
grep -R "Checking out to " koha-tmpl/*
koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt:            [% tx("Checking out to {patron}", { patron = patron_in_title }) | html %]
koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt:                            <label class="circ_barcode" for="barcode">Checking out to [% INCLUDE 'patron-title.inc' %]</label>
koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt:                        <h4>Checking out to [% INCLUDE 'patron-title.inc' %]</h4>
koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation_batch_checkouts.tt:                    <legend>Checking out to [% INCLUDE 'patron-title.inc' %]</legend>
koha-tmpl/intranet-tmpl/prog/fr-FR/modules/circ/circulation.tt: [% tx("Checking out to {patron}", { patron = patron_in_title }) | html %]

If I do this 'grep "Issuing" misc/translator/po/en-NZ*', I can see the following:

misc/translator/po/en-NZ-messages.po:msgstr "Issuing to {user}"

--

If I look at that file then I see the following:

7329 #: koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt:20
7330 #, perl-brace-format
7331 msgid "Checking out to {patron}"
7332 msgstr "Issuing to {user}"

--

There are similar issues further down:

7342 #: koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation_batch_checkouts.tt:16
7343 #, perl-brace-format
7344 msgid "Batch check out to {patron}"
7345 msgstr "Batch issue to {user}"

--

So overall I think this is a translation issue.
Comment 2 David Cook 2025-09-09 04:42:58 UTC
I tried running the following:
misc/translator/translate update en-NZ -v

But it didn't update the existing msgstr, since the msgid "Checking out to {patron}" is still the same I imagine.

So I imagine the solution will be to update the msgstr in Weblate?
Comment 3 David Cook 2025-09-09 04:48:39 UTC
(In reply to David Cook from comment #2)
> I tried running the following:
> misc/translator/translate update en-NZ -v
> 
> But it didn't update the existing msgstr, since the msgid "Checking out to
> {patron}" is still the same I imagine.
> 
> So I imagine the solution will be to update the msgstr in Weblate?

When I go on to Weblate and start looking at the messages, I see there's a warning that says the following:

Things to check
 Perl brace format 
The following format strings are missing: {patron}
The following format strings are extra: {user}
Comment 4 Wainui Witika-Park 2025-09-09 06:16:46 UTC
Thanks heaps David!