Bug 40785

Summary: Cronjob cleanup_database.pl usage is outdated
Product: Koha Reporter: Fridolin Somers <fridolin.somers>
Component: Command-line UtilitiesAssignee: Fridolin Somers <fridolin.somers>
Status: Pushed to stable --- QA Contact: Thomas Klausner <domm>
Severity: minor    
Priority: P5 - low CC: anke.bruns, domm, robin
Version: Main   
Hardware: All   
OS: All   
See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20555
GIT URL: Initiative type: ---
Sponsorship status: --- Crowdfunding goal: 0
Patch complexity: String patch Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
25.11.00,25.05.05
Circulation function:
Attachments: Bug 40785: Cronjob cleanup_database.pl remove args in usage first line
Bug 40785: Cronjob cleanup_database.pl remove args in usage first line
Bug 40785: Cronjob cleanup_database.pl remove args in usage first line

Description Fridolin Somers 2025-09-10 13:27:46 UTC
Cronjob cleanup_database.pl usage is wrong :
Usage: $0 [-h|--help] [--confirm] (...) [--bg-days DAYS [--bg-type TYPE] ]
Those args has been renamed jobs-days and jobs-type.
Also some args are missing.

There are too many args, I propose to remove them from there, one need to read the full help.
Comment 1 Fridolin Somers 2025-09-10 13:34:27 UTC
Created attachment 186326 [details] [review]
Bug 40785: Cronjob cleanup_database.pl remove args in usage first line

Cronjob cleanup_database.pl usage is wrong :
Usage: $0 [-h|--help] [--confirm] (...) [--bg-days DAYS [--bg-type TYPE] ]
Those args has been renamed jobs-days and jobs-type.
Also some args are missing.

There are too many args, I propose to remove them from there, one need to read the full help.

Test plan:
Run command line `misc/cronjobs/cleanup_database.pl -h`
You see first line:
Usage: misc/cronjobs/cleanup_database.pl

   -h --help          prints this help message, and exits, ignoring all
...
Comment 2 Anke Bruns 2025-10-08 12:12:36 UTC
Created attachment 187562 [details] [review]
Bug 40785: Cronjob cleanup_database.pl remove args in usage first line

Cronjob cleanup_database.pl usage is wrong :
Usage: $0 [-h|--help] [--confirm] (...) [--bg-days DAYS [--bg-type TYPE] ]
Those args has been renamed jobs-days and jobs-type.
Also some args are missing.

There are too many args, I propose to remove them from there, one need to read the full help.

Test plan:
Run command line `misc/cronjobs/cleanup_database.pl -h`
You see first line:
Usage: misc/cronjobs/cleanup_database.pl

   -h --help          prints this help message, and exits, ignoring all
...

Signed-off-by: Anke Bruns <anke.bruns@gwdg.de>
Comment 3 Thomas Klausner 2025-10-08 12:23:07 UTC
Created attachment 187564 [details] [review]
Bug 40785: Cronjob cleanup_database.pl remove args in usage first line

Cronjob cleanup_database.pl usage is wrong :
Usage: $0 [-h|--help] [--confirm] (...) [--bg-days DAYS [--bg-type TYPE] ]
Those args has been renamed jobs-days and jobs-type.
Also some args are missing.

There are too many args, I propose to remove them from there, one need to read the full help.

Test plan:
Run command line `misc/cronjobs/cleanup_database.pl -h`
You see first line:
Usage: misc/cronjobs/cleanup_database.pl

   -h --help          prints this help message, and exits, ignoring all
...

Signed-off-by: Anke Bruns <anke.bruns@gwdg.de>
Signed-off-by: Thomas Klausner <domm@plix.at>
Comment 4 Lucas Gass (lukeg) 2025-10-09 21:02:41 UTC
Nice work everyone!

Pushed to main for 25.11
Comment 5 Paul Derscheid 2025-10-29 09:09:54 UTC
Nice work everyone!

Pushed to 25.05.x