Bug 40840

Summary: Failure of an EDI SFTP account will kill edi_cron.pl preventing uploads from subsequent accounts
Product: Koha Reporter: Kyle M Hall (khall) <kyle>
Component: AcquisitionsAssignee: Kyle M Hall (khall) <kyle>
Status: Needs Signoff --- QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low    
Version: unspecified   
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: Trivial patch Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
Circulation function:
Attachments: Bug 40840: Failure of an EDI SFTP account will kill edi_cron.pl preventing uploads from subsequent accounts

Description Kyle M Hall (khall) 2025-09-18 17:53:27 UTC
EDI uploads are processed in order. If one account is unable to connect to the SFTP server, it will call die_on_error which kills the script. This does not affect regular FTP which will fail gracefully.
Comment 1 Kyle M Hall (khall) 2025-09-18 17:57:46 UTC
Created attachment 186574 [details] [review]
Bug 40840: Failure of an EDI SFTP account will kill edi_cron.pl preventing uploads from subsequent accounts

EDI uploads are processed in order. If one account is unable to connect to the SFTP server, it will call die_on_error which kills the script. This does not affect regular FTP which will fail gracefully.

Test Plan:
1) Set up an SFTP server
2) Set up 3 EDI accounts
3) Set accounts 1 and 3 to have a good SFTP server hostname
4) Set account 2 to have a bad SFTP server hostname
5) Queue an edi order for each account
6) Run edi_cron.pl
7) Note the cronjob runs and dies with an error
8) Note only 1 EDI message was uploaded
9) Apply this patch
10) Run edi_cron.pl
11) Note that the cronjob does not die
12) Verify the message for account 3 was uploaded! ( the message for
    account 2 should remain as pending ).