| Summary: | Job Status should not be Failed if a record import result in a item update | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Mathieu Saby <mathsabypro> |
| Component: | Tools | Assignee: | Nick Clemens (kidclamp) <nick> |
| Status: | Pushed to main --- | QA Contact: | Martin Renvoize (ashimema) <martin.renvoize> |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | lucas, nick |
| Version: | Main | Keywords: | release-notes-needed |
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | Unsponsored | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
26.05.00
|
|
| Circulation function: | |||
| Attachments: |
Bug 40846: Improve handling of ignored records
Bug 40846: Improve handling of ignored records Bug 40846: Improve handling of ignored records |
||
|
Description
Mathieu Saby
2025-09-22 12:41:40 UTC
Created attachment 188230 [details] [review] Bug 40846: Improve handling of ignored records Currently, a jobis marked failed if there are no records added or updated. We should take ignored records into account. Additionally, I mark the job failed when the number of records processed doesn't equal the number of records in the bacth To test: 1 - Export some records from your Koha, include some with items 2 - Stage and import those records into Koha, matching on biblionumber, ignoring matcheds, updating items 3 - View the import job, it is marked failed 4 - View the batch, all records imported 5 - Apply patch, restart all 6 - Stage/import as before 7 - Job is now marked finished 8 - Records imported as before Created attachment 190479 [details] [review] Bug 40846: Improve handling of ignored records Currently, a jobis marked failed if there are no records added or updated. We should take ignored records into account. Additionally, I mark the job failed when the number of records processed doesn't equal the number of records in the bacth To test: 1 - Export some records from your Koha, include some with items 2 - Stage and import those records into Koha, matching on biblionumber, ignoring matcheds, updating items 3 - View the import job, it is marked failed 4 - View the batch, all records imported 5 - Apply patch, restart all 6 - Stage/import as before 7 - Job is now marked finished 8 - Records imported as before Signed-off-by: David Nind <david@davidnind.com> Created attachment 191671 [details] [review] Bug 40846: Improve handling of ignored records Currently, a job is marked failed if there are no records added or updated. We should take ignored records into account. Additionally, I mark the job failed when the number of records processed doesn't equal the number of records in the batch. To test: 1) Export some records from your Koha, include some with items 2) Stage and import those records into Koha, matching on biblionumber, ignoring matcheds, updating items 3) View the import job, it is marked failed 4) View the batch, all records imported 5) Apply patch, restart all 6) Stage/import as before 7) Job is now marked finished 8) Records imported as before Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> Nice work everyone! Pushed to main for 26.05 please add release notes |