| Summary: | Patron circ messages not sorted in chronological order | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Laura Escamilla <Laura.escamilla> |
| Component: | Patrons | Assignee: | Laura Escamilla <Laura.escamilla> |
| Status: | Needs documenting --- | QA Contact: | Lucas Gass (lukeg) <lucas> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | aholt, andrew, baptiste.wojtkowski, bowens, christofer.zorn, davidm, eric, gmcharlt, jbarreto, jrobb, kebliss, kyle, lucas, wsmith |
| Version: | Main | Keywords: | rel_25_05_candidate |
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: |
This fixes a problem where circulation messages were not order chronologically in the staff interface.
|
Version(s) released in: |
25.11.00,25.05.05
|
| Circulation function: | |||
| Attachments: |
Bug 40886: Ensure patron messages display in proper chronological order
Bug 40886: Ensure patron messages display in proper chronological order Bug 40886: Ensure patron messages display in proper chronological order |
||
|
Description
Laura Escamilla
2025-09-26 15:33:23 UTC
Created attachment 186983 [details] [review] Bug 40886: Ensure patron messages display in proper chronological order 1. Create several random patron circ messages with different dates. I used the following sql for my ktd: -- INSERT INTO messages (borrowernumber, branchcode, message_type, message, message_date) SELECT 51 AS borrowernumber, 'CPL' AS branchcode, ELT(FLOOR(1 + (RAND() * 3)), 'L','B','E') AS message_type, -- L=Staff note, B=OPAC, E=Email (adjust to your codes) CONCAT('Random test message ', FLOOR(RAND()*1000)) AS message, DATE_ADD(CURDATE(), INTERVAL -FLOOR(RAND() * 1825) DAY) AS message_date -- random day in last ~5 years (5*365) FROM ( SELECT 1 UNION ALL SELECT 2 UNION ALL SELECT 3 UNION ALL SELECT 4 UNION ALL SELECT 5 UNION ALL SELECT 6 UNION ALL SELECT 7 UNION ALL SELECT 8 UNION ALL SELECT 9 UNION ALL SELECT 10 ) AS x; 2. View the patron account and notice that messages are sorted by type, but not by date. 3. Apply the patch and restart_all 4. Refresh the patron account page and clear the browser cache if necessary. 5. View the patron account again and notice that the messages are still sorted by type, but they are also sorted in descending order (newest to oldest). 6. Sign off and have a great day! A note on testing, one should not expect to have anything in the messages table with message_type=E. "E" is an option in add_message.pl, but selecting it tells Koha to put the message in the message_queue rather than in the messages table. An entry in the messages table with message_type "E" will end up styled as an OPAC message when viewing the patron record, which can make the sorting by type and then date appear to be incorrect. Created attachment 187136 [details] [review] Bug 40886: Ensure patron messages display in proper chronological order 1. Create several random patron circ messages with different dates. I used the following sql for my ktd: -- INSERT INTO messages (borrowernumber, branchcode, message_type, message, message_date) SELECT 51 AS borrowernumber, 'CPL' AS branchcode, ELT(FLOOR(1 + (RAND() * 3)), 'L','B','E') AS message_type, -- L=Staff note, B=OPAC, E=Email (adjust to your codes) CONCAT('Random test message ', FLOOR(RAND()*1000)) AS message, DATE_ADD(CURDATE(), INTERVAL -FLOOR(RAND() * 1825) DAY) AS message_date -- random day in last ~5 years (5*365) FROM ( SELECT 1 UNION ALL SELECT 2 UNION ALL SELECT 3 UNION ALL SELECT 4 UNION ALL SELECT 5 UNION ALL SELECT 6 UNION ALL SELECT 7 UNION ALL SELECT 8 UNION ALL SELECT 9 UNION ALL SELECT 10 ) AS x; 2. View the patron account and notice that messages are sorted by type, but not by date. 3. Apply the patch and restart_all 4. Refresh the patron account page and clear the browser cache if necessary. 5. View the patron account again and notice that the messages are still sorted by type, but they are also sorted in descending order (newest to oldest). 6. Sign off and have a great day! Signed-off-by: Jen Tormey <jntormey@dmpl.org> Created attachment 187427 [details] [review] Bug 40886: Ensure patron messages display in proper chronological order 1. Create several random patron circ messages with different dates. I used the following sql for my ktd: -- INSERT INTO messages (borrowernumber, branchcode, message_type, message, message_date) SELECT 51 AS borrowernumber, 'CPL' AS branchcode, ELT(FLOOR(1 + (RAND() * 3)), 'L','B','E') AS message_type, -- L=Staff note, B=OPAC, E=Email (adjust to your codes) CONCAT('Random test message ', FLOOR(RAND()*1000)) AS message, DATE_ADD(CURDATE(), INTERVAL -FLOOR(RAND() * 1825) DAY) AS message_date -- random day in last ~5 years (5*365) FROM ( SELECT 1 UNION ALL SELECT 2 UNION ALL SELECT 3 UNION ALL SELECT 4 UNION ALL SELECT 5 UNION ALL SELECT 6 UNION ALL SELECT 7 UNION ALL SELECT 8 UNION ALL SELECT 9 UNION ALL SELECT 10 ) AS x; 2. View the patron account and notice that messages are sorted by type, but not by date. 3. Apply the patch and restart_all 4. Refresh the patron account page and clear the browser cache if necessary. 5. View the patron account again and notice that the messages are still sorted by type, but they are also sorted in descending order (newest to oldest). 6. Sign off and have a great day! Signed-off-by: Jen Tormey <jntormey@dmpl.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> This patch fixes the problem described and is trivial. This is also hurting many libraries, I am taking the liberty to PQA here Nice work everyone! Pushed to main for 25.11 Could this be backported to 25.05? Nice work everyone! Pushed to 25.05.x Code not present in 24.11.x, fixing a bug introduced after 24.11.x, not backported |