Summary: | Invoice Adjustment Reason always "No reason" even if report shows a saved reason | ||
---|---|---|---|
Product: | Koha | Reporter: | Lisette Scheer <lisette> |
Component: | Acquisitions | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | Pushed to main --- | QA Contact: | Martin Renvoize (ashimema) <martin.renvoize> |
Severity: | critical | ||
Priority: | P5 - low | CC: | ephetteplace, jonathan.druart, martin.renvoize, me |
Version: | unspecified | Keywords: | regression, rel_25_05_candidate |
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: |
25.11.00
|
Circulation function: | |
Bug Depends on: | 38714 | ||
Bug Blocks: | |||
Attachments: |
Bug 40918: Fix invoice adjustement reason selection
Bug 40918: Fix invoice adjustement reason selection Bug 40918: Fix invoice adjustement reason selection |
Description
Lisette Scheer
2025-09-30 21:47:00 UTC
This reads like a data loss bug, upping severity. There is a foo here... Created attachment 187458 [details] [review] Bug 40918: Fix invoice adjustement reason selection From commit 46f7158f44ced21571dc9deef9ca240fc34a8e6b Bug 38714: acqui/invoice.tt Debugging stuff left, sorry! Test plan: 1. Go to Acquisition. 2. Create a vendor. 3. Click "Receive Shipment" 4. Enter an invoice number and save. 5. Go to Administration->Authorized Values->Add A Category 6. Name it ADJ_REASON 7. Put in 2 options 8. Go to invoices in Aqusition 9. Add an adjustment (enter an amount and select a reason, then save) 10. The reason is set to "no reason" 11. Go to reports 12. new sql report select * from aqinvoice_adjustments 13. Run the report and see your reason is saved. 14. go back to the invoice and click save adjustments 15. Run the report and see your reason is saved. Created attachment 187502 [details] [review] Bug 40918: Fix invoice adjustement reason selection From commit 46f7158f44ced21571dc9deef9ca240fc34a8e6b Bug 38714: acqui/invoice.tt Debugging stuff left, sorry! Test plan: 1. Go to Acquisition. 2. Create a vendor. 3. Click "Receive Shipment" 4. Enter an invoice number and save. 5. Go to Administration->Authorized Values->Add A Category 6. Name it ADJ_REASON 7. Put in 2 options 8. Go to invoices in Aqusition 9. Add an adjustment (enter an amount and select a reason, then save) 10. The reason is set to "no reason" 11. Go to reports 12. new sql report select * from aqinvoice_adjustments 13. Run the report and see your reason is saved. 14. go back to the invoice and click save adjustments 15. Run the report and see your reason is saved. Signed-off-by: Eric Phetteplace <ephetteplace@cca.edu> Created attachment 187666 [details] [review] Bug 40918: Fix invoice adjustement reason selection From commit 46f7158f44ced21571dc9deef9ca240fc34a8e6b Bug 38714: acqui/invoice.tt Debugging stuff left, sorry! Test plan: 1. Go to Acquisition. 2. Create a vendor. 3. Click "Receive Shipment" 4. Enter an invoice number and save. 5. Go to Administration->Authorized Values->Add A Category 6. Name it ADJ_REASON 7. Put in 2 options 8. Go to invoices in Aqusition 9. Add an adjustment (enter an amount and select a reason, then save) 10. The reason is set to "no reason" 11. Go to reports 12. new sql report select * from aqinvoice_adjustments 13. Run the report and see your reason is saved. 14. go back to the invoice and click save adjustments 15. Run the report and see your reason is saved. Signed-off-by: Eric Phetteplace <ephetteplace@cca.edu> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> Nice work everyone! Pushed to main for 25.11 |