Bug 40919

Summary: Unnecessary DB access in Koha::Item::Transfer->receive
Product: Koha Reporter: Tomás Cohen Arazi (tcohen) <tomascohen>
Component: Architecture, internals, and plumbingAssignee: Tomás Cohen Arazi (tcohen) <tomascohen>
Status: Needs Signoff --- QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: tomascohen
Version: unspecified   
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: --- Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
Circulation function:
Bug Depends on: 25767    
Bug Blocks:    
Attachments: Bug 40919: Remove unnecessary DB call in Koha::Item::Transfer->receive

Description Tomás Cohen Arazi (tcohen) 2025-09-30 22:24:17 UTC
This line:

```perl
    ModDateLastSeen( $self->item->itemnumber );
```

could just be

```perl
    ModDateLastSeen( $self->itemnumber );
```

There's no need to instantiate the related Koha::Item object.
Comment 1 Tomás Cohen Arazi (tcohen) 2025-09-30 22:29:45 UTC
Created attachment 187143 [details] [review]
Bug 40919: Remove unnecessary DB call in Koha::Item::Transfer->receive

This patch removes a trivially not required DB object instantiation.
This implies saving CPU usage for the instantiation and algo for
fetching from the DB.

To test:
1. Run:
   $ ktd --shell
  k$ prove t/db_dependent/Koha/Item/Transfer.t
=> SUCCESS: Tests pass! They cover ->receive()
2. Apply this patch
3. Repeat 1
=> SUCCESS: No behavior change, tests pass!
4. Sign off :-D