Bug 40955

Summary: SIP: Add a message on successful checkin with a hold
Product: Koha Reporter: Marion Durand <marion.durand>
Component: SIP2Assignee: Marion Durand <marion.durand>
Status: Failed QA --- QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low    
Version: Main   
Hardware: All   
OS: All   
GIT URL: Initiative type: ---
Sponsorship status: --- Comma delimited list of Sponsors:
Crowdfunding goal: 0 Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:
Attachments: Bug 40995: SIP add a message at checkin for document with hold

Description Marion Durand 2025-10-06 10:25:39 UTC
Bug 25814 add some screen message (AF) for successful checkin.

It would be great to add a specific message when the item checked in is on hold (it might be used to tell the patron to place the document on a specific shelf).
Comment 1 Marion Durand 2025-10-06 12:54:03 UTC
Created attachment 187473 [details] [review]
Bug 40995: SIP add a message at checkin for document with hold

Bug 40995: SIP add a message at checkin for document with hold

Add a screen message (AF) when a document with a hold is checked in.
Only show when the parameter show_checkin_message is set to 1.

To test:
1- Checkout a document to a patron A
2- Place a hold for patron B for this document
3- Do a checking using SIP 4- Check that the screen message (AF field)
    contain a text warning that the item is on hold, and that the return
    has been correctly done
Comment 2 Katrin Fischer 2026-02-03 18:25:00 UTC
Hi Marion,

some first notes:

1) QA tests pass

2) Code review

a) Terminology

"Item reserved by another patron"

We need to use "hold" instead of "reserve" 
See: https://wiki.koha-community.org/wiki/Terminology#R

Suggestion:
"There is a hold for another patron on the item"

Do we need the information, that the hold is for another patron or could it just be:

"There is a hold on the item" ?

b) Unit tests

I wonder if there should be a unit test. We do have tests for the other message in this section in t/db_dependent/SIP/Transaction.t.