Bug 40968

Summary: 'Edit this search' forgets about 'whole_records' and 'weighted_fields'
Product: Koha Reporter: Tomás Cohen Arazi (tcohen) <tomascohen>
Component: Searching - ElasticsearchAssignee: Tomás Cohen Arazi (tcohen) <tomascohen>
Status: Needs Signoff --- QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: tomascohen
Version: unspecified   
Hardware: All   
OS: All   
GIT URL: Initiative type: ---
Sponsorship status: --- Comma delimited list of Sponsors:
Crowdfunding goal: 0 Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:
Bug Depends on: 40966    
Bug Blocks:    
Attachments: Bug 40968: Make 'Edit this search' aware of 'whole_records' and 'weighted_fields'
Bug 40968: Make 'Edit this search' aware of 'whole_records' and 'weighted_fields'

Description Tomás Cohen Arazi (tcohen) 2025-10-07 17:32:11 UTC
Found it while playing with links on bug 40966.

To reproduce:
1. Apply bug 40966
2. Perform an adv search as in that bug. Using the 'More options' tab.
3. Include any of the following options (or both):
   * Search entire MARC record
   * Apply field weights to search
4. Notice the facets include 'whole_records=1' and/or 'weighted_fields=1' (this is the bug 40966 patch in action)
5. hover the 'Edit this search' link
=> SUCCESS: It gets the query parameters passed through
6. Click on the link
=> FAIL: None is really set, we lost search information.
Comment 1 Tomás Cohen Arazi (tcohen) 2025-10-07 18:36:47 UTC
Created attachment 187544 [details] [review]
Bug 40968: Make 'Edit this search' aware of 'whole_records' and 'weighted_fields'

This patch makes the advanced search page that gets pre-filled with
previous searches (a.k.a 'Edit this search') behave like this:

* 'More options' is preselected if any of 'whole_records' or
  'weighted_fields' query parameters are passed
* In Edit-mode, the checkboxes for those are pre-filled with the passed
  values
* In normal mode, the current behavior is preserved to avoid changing
  it.

To test:
1. Apply bug 40966
2. Perform an adv search as in that bug. Using the 'More options' tab.
3. Include any of the following options (or both):
   * Search entire MARC record
   * Apply field weights to search
4. Notice the facets include 'whole_records=1' and/or 'weighted_fields=1' (this is the bug 40966 patch in action)
5. hover the 'Edit this search' link
=> SUCCESS: It gets the query parameters passed through
6. Click on the link
=> FAIL: None is really set, we lost search information.
7. Go back to the search results
8. Apply this patch
9. Refresh the page
10. Click on the 'Edit this search' link
=> SUCCESS: The page is pre-loaded with the right values for 'Search
entire MARC record' and 'Apply field weights to search'
11. Sign off :-D
Comment 2 Tomás Cohen Arazi (tcohen) 2025-10-16 13:30:53 UTC
Created attachment 188008 [details] [review]
Bug 40968: Make 'Edit this search' aware of 'whole_records' and 'weighted_fields'

This patch makes the advanced search page that gets pre-filled with
previous searches (a.k.a 'Edit this search') behave like this:
* 'More options' is preselected if any of 'whole_records' or
  'weighted_fields' query parameters are passed (as weighted_fields is
on by default, we rely on a new parameter to achieve this)
* In Edit-mode, the checkboxes for those are pre-filled with the passed
  values
* In normal mode, the current behavior is preserved to avoid changing
  it.
To test:
1. Apply bug 40966
2. Perform an adv search as in that bug. Using the 'More options' tab.
3. Include any of the following options (or both):
   * Search entire MARC record
   * Apply field weights to search
4. Notice the facets include 'whole_records=1' and/or 'weighted_fields=1' (this is the bug 40966 patch in action)
5. hover the 'Edit this search' link
=> SUCCESS: It gets the query parameters passed through
6. Click on the link
=> FAIL: None is really set, we lost search information.
7. Go back to the search results
8. Apply this patch
9. Refresh the page
10. Click on the 'Edit this search' link
=> SUCCESS: The page is pre-loaded with the right values for 'Search
entire MARC record' and 'Apply field weights to search'
11. Sign off :-D
Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io>
Comment 3 Tomás Cohen Arazi (tcohen) 2025-10-16 13:30:55 UTC
This patch makes the advanced search page that gets pre-filled with
previous searches (a.k.a 'Edit this search') behave like this:
* 'More options' is preselected if any of 'whole_records' or
  'weighted_fields' query parameters are passed (as weighted_fields is
on by default, we rely on a new parameter to achieve this)
* In Edit-mode, the checkboxes for those are pre-filled with the passed
  values
* In normal mode, the current behavior is preserved to avoid changing
  it.
To test:
1. Apply bug 40966
2. Perform an adv search as in that bug. Using the 'More options' tab.
3. Include any of the following options (or both):
   * Search entire MARC record
   * Apply field weights to search
4. Notice the facets include 'whole_records=1' and/or 'weighted_fields=1' (this is the bug 40966 patch in action)
5. hover the 'Edit this search' link
=> SUCCESS: It gets the query parameters passed through
6. Click on the link
=> FAIL: None is really set, we lost search information.
7. Go back to the search results
8. Apply this patch
9. Refresh the page
10. Click on the 'Edit this search' link
=> SUCCESS: The page is pre-loaded with the right values for 'Search
entire MARC record' and 'Apply field weights to search'
11. Sign off :-D
Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io>