Bug 40969

Summary: Circulation.t fails if RenewalPeriodBase is set to now ( the current date )
Product: Koha Reporter: Lucas Gass (lukeg) <lucas>
Component: Test SuiteAssignee: Lucas Gass (lukeg) <lucas>
Status: RESOLVED FIXED QA Contact: Nick Clemens (kidclamp) <nick>
Severity: normal    
Priority: P5 - low CC: david, fridolin.somers, wainuiwitikapark
Version: Main   
Hardware: All   
OS: All   
GIT URL: Initiative type: ---
Sponsorship status: --- Comma delimited list of Sponsors:
Crowdfunding goal: 0 Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
25.11.00,25.05.05,24.11.11
Circulation function:
Bug Depends on:    
Bug Blocks: 30331    
Attachments: Bug 40969: Mock the enewalPeriodBase preference correctly
Bug 40969: Mock the RenewalPeriodBase preference correctly
Bug 40969: Mock the enewalPeriodBase preference correctly
Bug 40969: Mock the RenewalPeriodBase preference correctly

Description Lucas Gass (lukeg) 2025-10-07 19:27:40 UTC
I think we need to correctly mock the pref
Comment 1 Lucas Gass (lukeg) 2025-10-07 19:29:06 UTC
Created attachment 187550 [details] [review]
Bug 40969: Mock the enewalPeriodBase preference correctly
Comment 2 Andrew Fuerste-Henry 2025-10-10 17:45:27 UTC
Created attachment 187756 [details] [review]
Bug 40969: Mock the RenewalPeriodBase preference correctly

Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org>
Comment 3 Nick Clemens (kidclamp) 2025-10-16 18:24:27 UTC
Created attachment 188026 [details] [review]
Bug 40969: Mock the enewalPeriodBase preference correctly

Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 4 Nick Clemens (kidclamp) 2025-10-20 16:17:37 UTC
Created attachment 188172 [details] [review]
Bug 40969: Mock the RenewalPeriodBase preference correctly

Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 5 Lucas Gass (lukeg) 2025-10-21 14:48:17 UTC
Pushed to main for 25.11.00
Comment 6 Paul Derscheid 2025-10-29 09:10:18 UTC
Nice work everyone!

Pushed to 25.05.x
Comment 7 Fridolin Somers 2025-11-10 15:21:45 UTC
Pushed to 24.11.x for 24.11.11
Comment 8 Wainui Witika-Park 2026-01-16 00:04:49 UTC
Not backporting to 22.11.x
Comment 9 David Nind 2026-01-16 21:45:54 UTC
Test suite related, no changes to the manual required.