| Summary: | t/db_dependent/Budgets.t fails on Debian 13 due to warnings | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Victor Grousset/tuxayo <victor> |
| Component: | Architecture, internals, and plumbing | Assignee: | Jonathan Druart <jonathan.druart> |
| Status: | Pushed to oldstable --- | QA Contact: | Marcel de Rooy <m.de.rooy> |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | dcook, fridolin.somers, jonathan.druart, m.de.rooy |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
25.11.00,25.05.05,24.11.11
|
|
| Circulation function: | |||
| Bug Depends on: | |||
| Bug Blocks: | 41077 | ||
| Attachments: |
Bug 40978: Remove warnings from Budgets.t
Bug 40978: Remove warnings from Budgets.t Bug 40978: Remove warnings from Budgets.t Bug 40978: Remove warnings from Budgets.t Bug 40978: Remove warnings from Budgets.t |
||
Created attachment 187719 [details] [review] Bug 40978: Remove warnings from Budgets.t If no shipment_budget is set then undef is set as key of the hashref which generates a warning: Use of uninitialized value $row[0] in hash element at /usr/lib/x86_64-linux-gnu/perl5/5.40/DBI.pm line 2122. Later we only access the hashref by budget_id, so this change seems safe. Created attachment 187780 [details] [review] Bug 40978: Remove warnings from Budgets.t If no shipment_budget is set then undef is set as key of the hashref which generates a warning: Use of uninitialized value $row[0] in hash element at /usr/lib/x86_64-linux-gnu/perl5/5.40/DBI.pm line 2122. Later we only access the hashref by budget_id, so this change seems safe. Created attachment 187781 [details] [review] Bug 40978: Remove warnings from Budgets.t If no shipment_budget is set then undef is set as key of the hashref which generates a warning: Use of uninitialized value $row[0] in hash element at /usr/lib/x86_64-linux-gnu/perl5/5.40/DBI.pm line 2122. Later we only access the hashref by budget_id, so this change seems safe. Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> It works! Created attachment 188060 [details] [review] Bug 40978: Remove warnings from Budgets.t If no shipment_budget is set then undef is set as key of the hashref which generates a warning: Use of uninitialized value $row[0] in hash element at /usr/lib/x86_64-linux-gnu/perl5/5.40/DBI.pm line 2122. Later we only access the hashref by budget_id, so this change seems safe. Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Created attachment 188399 [details] [review] Bug 40978: Remove warnings from Budgets.t If no shipment_budget is set then undef is set as key of the hashref which generates a warning: Use of uninitialized value $row[0] in hash element at /usr/lib/x86_64-linux-gnu/perl5/5.40/DBI.pm line 2122. Later we only access the hashref by budget_id, so this change seems safe. Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Nice work everyone! Pushed to main for 25.11 Nice work everyone! Pushed to 25.05.x Pushed to 24.11.x for 24.11.11 |
Test plan 1. KOHA_IMAGE=main-bookworm ktd up 2. prove t/db_dependent/Budgets.t 3. pass 4. KOHA_IMAGE=main-trixie ktd up 5. prove t/db_dependent/Budgets.t # Failed test 'no warnings' # at /usr/share/perl/5.40/Test/Builder.pm line 193. # There were 30 warning(s) # Previous test 65 'total ordered price is 20' # Use of uninitialized value $row[0] in hash element at /usr/lib/x86_64-linux-gnu/perl5/5.40/DBI.pm line 2122. # at /usr/lib/x86_64-linux-gnu/perl5/5.40/DBI.pm line 2122. # DBD::_::st::fetchall_hashref(DBI::st=HASH(0x557454dac660), "budget_id") called at /usr/lib/x86_64-linux-gnu/perl5/5.40/DBD/mysql.pm line 866 # DBD::mysql::st::__ANON__(DBI::st=HASH(0x557454dac660), "budget_id") called at /usr/lib/x86_64-linux-gnu/perl5/5.40/DBI.pm line 1684 # DBD::_::db::selectall_hashref(DBI::db=HASH(0x557454733ab0), "\x{a} SELECT shipmentcost_budgetid as budget_id,\x{a} "..., "budget_id") called at /kohadevbox/koha/C4/Budgets.pm line 750 # C4::Budgets::GetBudgetHierarchy(36) called at /kohadevbox/koha/C4/Budgets.pm line 1442 # C4::Budgets::CloneBudgetPeriod(HASH(0x557454dc9ca0)) called at t/db_dependent/Budgets.t line 598 # etc Maybe you need to apply bug 40680 if there are other warnings interfering. Or just ignore them and focus on the "Use of uninitialized value" ones. Severity = major because it makes the CI fail and hides issues even if not as much as Bug 40680. Maybe critical, I don't know.