Bug 40981

Summary: KohaTable/Holdings_spec.ts is failing randomly
Product: Koha Reporter: Jonathan Druart <jonathan.druart>
Component: Test SuiteAssignee: Jonathan Druart <jonathan.druart>
Status: RESOLVED FIXED QA Contact: Lucas Gass (lukeg) <lucas>
Severity: normal    
Priority: P5 - low CC: david, fridolin.somers, lucas
Version: unspecified   
Hardware: All   
OS: All   
GIT URL: Initiative type: ---
Sponsorship status: --- Comma delimited list of Sponsors:
Crowdfunding goal: 0 Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
25.11.00,25.05.05
Circulation function:
Attachments: Bug 40981: Prevent KohaTable/Holdings_spec.ts to fail randomly
Bug 40981: Prevent KohaTable/Holdings_spec.ts to fail randomly
Bug 40981: Prevent KohaTable/Holdings_spec.ts to fail randomly

Description Jonathan Druart 2025-10-09 09:26:19 UTC
The following error originated from your application code, not from Cypress.

  > DataTables warning detected in log: "DataTables warning: table id=holdings_table - Ajax error. For more information about this error, please see https://datatables.net/tn/7"
Comment 1 Jonathan Druart 2025-10-09 09:33:59 UTC
Created attachment 187647 [details] [review]
Bug 40981: Prevent KohaTable/Holdings_spec.ts to fail randomly

There is a JS warning raised by DT which makes the tests fail:
```
The following error originated from your application code, not from Cypress.

  > DataTables warning detected in log: "DataTables warning: table id=holdings_table - Ajax error. For more information about this error, please see https://datatables.net/tn/7"
```

It is caused by a 404 returned by the API, because DT receives the
response during the afterEach (after the objects have been deleted)

We must wait for the responses when needed.

Test plan:
  cypress run --spec t/cypress/integration/KohaTable/Holdings_spec.ts
should still pass
Comment 2 Jonathan Druart 2025-10-09 09:55:11 UTC
Created attachment 187648 [details] [review]
Bug 40981: Prevent KohaTable/Holdings_spec.ts to fail randomly

There is a JS warning raised by DT which makes the tests fail:
```
The following error originated from your application code, not from Cypress.

  > DataTables warning detected in log: "DataTables warning: table id=holdings_table - Ajax error. For more information about this error, please see https://datatables.net/tn/7"
```

It is caused by a 404 returned by the API, because DT receives the
response during the afterEach (after the objects have been deleted)

We must wait for the responses when needed.

Test plan:
  cypress run --spec t/cypress/integration/KohaTable/Holdings_spec.ts
should still pass
Comment 3 Lucas Gass (lukeg) 2025-10-09 13:05:26 UTC
Created attachment 187658 [details] [review]
Bug 40981: Prevent KohaTable/Holdings_spec.ts to fail randomly

There is a JS warning raised by DT which makes the tests fail:
```
The following error originated from your application code, not from Cypress.

  > DataTables warning detected in log: "DataTables warning: table id=holdings_table - Ajax error. For more information about this error, please see https://datatables.net/tn/7"
```

It is caused by a 404 returned by the API, because DT receives the
response during the afterEach (after the objects have been deleted)

We must wait for the responses when needed.

Test plan:
  cypress run --spec t/cypress/integration/KohaTable/Holdings_spec.ts
should still pass

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 4 Lucas Gass (lukeg) 2025-10-09 13:26:43 UTC
Pushed to main for 25.11.00
Comment 5 Paul Derscheid 2025-10-29 09:10:23 UTC
Nice work everyone!

Pushed to 25.05.x
Comment 6 Fridolin Somers 2025-11-10 13:50:54 UTC
Does not apply easy on 24.11.x, I skip
Comment 7 David Nind 2025-11-13 02:35:17 UTC
Test suite related, no changes to the manual required.