|
Description
Marcel de Rooy
2025-10-10 09:42:55 UTC
Created attachment 187723 [details] [review] Bug 40993: Add Apache RewriteRule for hitting value_builder pages Test plan: Copy this file to /etc/koha. Restart Apache. Login to staff and hit a value builder page directly, e.g.: YOUR_SERVER/cgi-bin/koha/cataloguing/value_builder/marc21_field_005.pl Verify that you got redirected to 403. Verify that you can still edit a biblio record and open e.g. the leader plugin form. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Your follow-up here would be appreciated. Thanks. (In reply to Marcel de Rooy from comment #2) > Your follow-up here would be appreciated. Thanks. Catching up on my emails, but I'm adding a note to review this as soon as I can. At a glance, it looks pretty good although I think I might have a change to make. Removing the dependency on bug 40943 because it doesn't require it to function. Moving it to See Also instead. Before the patch, I go to http://localhost:8081/cgi-bin/koha/cataloguing/value_builder/marc21_field_005.pl and it gives me a 500 With the patch: - sudo cp debian/templates/apache-shared-intranet.conf /etc/koha/apache-shared-intranet.conf - sudo service apache2 restart And that doesn't work because KTD doesn't use /etc/koha/apache-shared-intranet.conf it uses /etc/koha/apache-shared-intranet-git.conf So I'll manually include the line into /etc/koha/apache-shared-intranet-git.conf And that's looking good. I just have one tweak to make. Created attachment 188185 [details] [review] Bug 40993: (QA follow-up) use L flag to stop the rewrite after PT action Signed-off-by: David Cook <dcook@prosentient.com.au> Created attachment 188186 [details] [review] Bug 40993: Add Apache RewriteRule for hitting value_builder pages Test plan: Copy this file to /etc/koha. Restart Apache. Login to staff and hit a value builder page directly, e.g.: YOUR_SERVER/cgi-bin/koha/cataloguing/value_builder/marc21_field_005.pl Verify that you got redirected to 403. Verify that you can still edit a biblio record and open e.g. the leader plugin form. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Cook <dcook@prosentient.com.au> Created attachment 188187 [details] [review] Bug 40993: (QA follow-up) use L flag to stop the rewrite after PT action Signed-off-by: David Cook <dcook@prosentient.com.au> (In reply to David Cook from comment #7) > Created attachment 188187 [details] [review] [review] > Bug 40993: (QA follow-up) use L flag to stop the rewrite after PT action > > Signed-off-by: David Cook <dcook@prosentient.com.au> Ah great, thx. |