Bug 40997

Summary: Javascript error prevents saving when an instance of an 'important field is deleted
Product: Koha Reporter: Nick Clemens (kidclamp) <nick>
Component: CatalogingAssignee: Nick Clemens (kidclamp) <nick>
Status: Needs Signoff --- QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: m.de.rooy
Version: Main   
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: --- Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
Circulation function:
Attachments: Bug 40997: Don't check elements that have been removed
Bug 40997: Remove uneccessary whitespace

Description Nick Clemens (kidclamp) 2025-10-10 15:34:22 UTC
When a record has multiple instances of a field marked as 'important' and a cataloger removes one or more of the instances, and one is left in place, saving the record fails with:

Uncaught TypeError: can't access property "getElementsByTagName", elem is null
    AreFieldsNotOk http://localhost:8081/cgi-bin/koha/cataloguing/addbiblio.pl?biblionumber=0&z3950=1&frameworkcode=Default&breedingid=38:3841
    Check http://localhost:8081/cgi-bin/koha/cataloguing/addbiblio.pl?biblionumber=0&z3950=1&frameworkcode=Default&breedingid=38:3923
    onOption http://localhost:8081/cgi-bin/koha/cataloguing/addbiblio.pl?biblionumber=0&z3950=1&frameworkcode=Default&breedingid=38:782
    <anonymous> http://localhost:8081/cgi-bin/koha/cataloguing/addbiblio.pl?biblionumber=0&z3950=1&frameworkcode=Default&breedingid=38:698
    jQuery 2


To recreate:
1 - In Admin - MARC bibliographic frameworks  edit the default framewwork and edit 650 tag and mark it as important
2 - Go to cataloging -> new from z39.50
3 - Find a record with mulltiple 650 fields
4 - Delete one of the fields
5 - Attempt to save the record - nothing happens
6 - Check the console log in the browser, see the error noted above
Comment 1 Nick Clemens (kidclamp) 2025-10-10 18:44:30 UTC
Created attachment 187766 [details] [review]
Bug 40997: Don't check elements that have been removed
Comment 2 Nick Clemens (kidclamp) 2025-10-10 18:44:34 UTC
Created attachment 187767 [details] [review]
Bug 40997: Remove uneccessary whitespace