| Summary: | Using Show Checkouts button when LoadCheckoutsTableDelay is set causes collision/error. loadIssuesTableDelayTimeoutId not assigned | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Michael Grgurev <mike.grgurev> |
| Component: | Circulation | Assignee: | Michael Grgurev <mike.grgurev> |
| Status: | Failed QA --- | QA Contact: | Testopia <testopia> |
| Severity: | minor | ||
| Priority: | P4 | CC: | gmcharlt, jonathan.druart, kyle, lucas |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: | [PATCH] Bug 41058: Assign timeout id when delaying issues table load | ||
Can you attach your patch here? Created attachment 188492 [details] [review] [PATCH] Bug 41058: Assign timeout id when delaying issues table load Well.. hopefully I formatted this right. Hey Michael, The code changes here look good! A few thing to point out: -The commit message should always start with "Bug XXXXX: " or else the Koha QA tools will complain, -Your must attach a test plan to your commit. If you can do those 2 things we can move this along. And thanks for the patch! Ahhh, thanks Lucas! I knew my workflow was probably out of whack somewhere. Thought I had both of those in my patch file, but I'm clearly formatting/applying something wrong. I'll review everything and resubmit. |
Manually selecting the "Show Checkouts" button does not cancel the setTimeout associated with LoadCheckoutsTableDelay (Checkouts table will show automatically in blah seconds..) In /intranet-tmpl/prog/js/checkouts.js, loadIssuesTableDelayTimeoutId is declared and targeted by clearTimeout() but never applied to the setTimeout() that triggers LoadIssuesTable(). Lines 712 & 735 should be revised from "setTimeout(function () {" to "loadIssuesTableDelayTimeoutId = setTimeout(function () {"