| Summary: | Zotero connector broken by bug 37370 | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Martin Renvoize (ashimema) <martin.renvoize> |
| Component: | Web services | Assignee: | Tomás Cohen Arazi (tcohen) <tomascohen> |
| Status: | Needs Signoff --- | QA Contact: | Testopia <testopia> |
| Severity: | major | ||
| Priority: | P5 - low | CC: | david, lauren_denny, lucas, tomascohen |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | 37370 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 41084: Add EnableZotero system preference
Bug 41084: Allow utf8 export format when EnableZotero is enabled Bug 41084: Allow utf8 export format when EnableZotero is enabled Bug 41084: Add EnableZotero system preference Bug 41084: Allow utf8 export format when EnableZotero is enabled |
||
|
Description
Martin Renvoize (ashimema)
2025-10-23 13:22:56 UTC
Perhaps a possible solution is a second preference to allow Zotero specifically for export.. and use that to trigger an allow on utf8 export even if it's not selected in the UI facing preference? Created attachment 190775 [details] [review] Bug 41084: Add EnableZotero system preference This system preference will be used to enable opac-export.pl?format=utf8 regardless of the OpacExportOptions values, specifically for Zotero integration support. Created attachment 190776 [details] [review] Bug 41084: Allow utf8 export format when EnableZotero is enabled When the EnableZotero system preference is enabled, allow the utf8 format in opac-export.pl regardless of the OpacExportOptions settings. This enables Zotero integration by ensuring the required UTF-8 encoded MARC format is always available when the feature is enabled. Created attachment 190777 [details] [review] Bug 41084: Allow utf8 export format when EnableZotero is enabled When the EnableZotero system preference is enabled, allow the utf8 format in opac-export.pl regardless of the OpacExportOptions settings. This enables Zotero integration by ensuring the required UTF-8 encoded MARC format is always available when the feature is enabled. To test: 1. Install Zotero (https://www.zotero.org) 2. Install the browser extension (I did in in Chrome, not sure it exists for FF) 3. Perform a search in your koha instance. e.g. http://kohadev.localhost/cgi-bin/koha/opac-search.pl?idx=&q=agrovoc&weight_search=1 4. Open the Zotero extension => SUCCESS: It lists the search results for saving them 5. Choose one and save => FAIL: It says there was an error saving 6. Apply this patches 7. Run: $ ktd --shell k$ updatedatabase 8. Make sure EnableZotero is enabled 9. Repeat 3-5 => SUCCESS: All good this time 10. Sign off :-D Created attachment 190778 [details] [review] Bug 41084: Add EnableZotero system preference This system preference will be used to enable opac-export.pl?format=utf8 regardless of the OpacExportOptions values, specifically for Zotero integration support. Created attachment 190779 [details] [review] Bug 41084: Allow utf8 export format when EnableZotero is enabled When the EnableZotero system preference is enabled, allow the utf8 format in opac-export.pl regardless of the OpacExportOptions settings. This enables Zotero integration by ensuring the required UTF-8 encoded MARC format is always available when the feature is enabled. To test: 1. Install Zotero (https://www.zotero.org) 2. Install the browser extension (I did in in Chrome, not sure it exists for FF) 3. Perform a search in your koha instance. e.g. http://kohadev.localhost/cgi-bin/koha/opac-search.pl?idx=&q=agrovoc&weight_search=1 4. Open the Zotero extension => SUCCESS: It lists the search results for saving them 5. Choose one and save => FAIL: It says there was an error saving 6. Apply this patches 7. Run: $ ktd --shell k$ updatedatabase 8. Make sure EnableZotero is enabled 9. Repeat 3-5 => SUCCESS: All good this time 10. Sign off :-D I'm not seeing any error when using the Zotero connector for the browsers I use (I've used Zotero for a while, on and off). For me, it seems to work OK from: - The search results page - Individual bibliographic record pages My set up: - Zotero version: 7.0.30 (the latest) - Browser: Firefox connector - Browser: Chrome connector - There are also connectors for Edge and Safari (bundled with the Zotero Connector for Safari) - Operating system: Ubuntu 22.04 I can test on Windows if that would help. (In reply to David Nind from comment #7) > I'm not seeing any error when using the Zotero connector for the browsers I > use (I've used Zotero for a while, on and off). > > For me, it seems to work OK from: > - The search results page > - Individual bibliographic record pages > > My set up: > - Zotero version: 7.0.30 (the latest) > - Browser: Firefox connector > - Browser: Chrome connector > - There are also connectors for Edge and Safari (bundled with the Zotero > Connector for Safari) > - Operating system: Ubuntu 22.04 > > I can test on Windows if that would help. Have you disabled all export options? (In reply to Tomás Cohen Arazi (tcohen) from comment #8) > > Have you disabled all export options? I hadn't! If no options are selected for OpacExportOptions, I now get the error. Other testing notes, after the patches, the book details are saved in Zotero no matter what I set. That is, it makes no difference if I set EnableZotero or not or OpacExportOptions or not, or any combination. The only exception is with "Don't enable" and "none selected", there is a Zotero plugin error. The record is still saved into Zotero anyway. 1. If I set - EnableZotero = Enable - OpacExportOptions: All selected ==> Book details saved in Zotero 3. If I set - EnableZotero = Enable - OpacExportOptions: None selected ==> Book details saved in Zotero 4. If I set - EnableZotero = Don't enable - OpacExportOptions: All selected ==> Book details saved in Zotero 5. If I set - EnableZotero = Don't enable - OpacExportOptions: None selected ==> There is an error for the Zotero plugin "An error occurred saving with Library Catalog (Koha). Attempting to save using unAPI instead." ==> Book details saved in Zotero In terms of the description for the EnableZotero system preference, I don't understand what it means. This also seems to be causing t/db_dependent/api/v1/holds.t to fail. (In reply to Lucas Gass (lukeg) from comment #10) > This also seems to be causing t/db_dependent/api/v1/holds.t to fail. Please ignore me, I'm clearly lost. :( |