| Summary: | Selectors are inconsistently structured in hold found modals | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Andrew Fuerste-Henry <andrew> |
| Component: | Staff interface | Assignee: | Andrew Fuerste-Henry <andrew> |
| Status: | Needs Signoff --- | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | gmcharlt |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Crowdfunding goal: | 0 |
| Patch complexity: | --- | Documentation contact: | |
| Documentation submission: | Text to go in the release notes: | ||
| Version(s) released in: | Circulation function: | ||
| Attachments: | Bug 41116: Standardize selectors in patron contact information in hold found modals | ||
|
Description
Andrew Fuerste-Henry
2025-10-27 20:15:37 UTC
Created attachment 188517 [details] [review] Bug 41116: Standardize selectors in patron contact information in hold found modals This patch modifies both hold-found-modal and hold-found1. It adds a class to the patron phone number. For patron email, it changes the existing id to a class, expands the selector to include the bullet point in hold-found-modal, and standardizes the name (changing from "#boreamil' to ".patronemail"). To test: 1 - have a patron with both a phone number and an email address 2 - create a hold for your patron 3 - check an item in to fill your hold, triggering the hold-found-modal 4 - inspect the patron contact info, confirm there is no class on the phone number 5 - confirm there is an id on the patron email but it does not include the bullet point and is inconsistent with the names of other classes in the modal 6 - click Confirm Hold 7 - check your item in again, triggering the hold-found1 modal 8 - confirm there is no class on the patron phone number 9 - confirm there is an id on the patron email with an inconsistent name 10 - revert the waiting status of your hold 11 - apply patch, restart_all 12 - check your item in again, triggering hold-found-modal 13 - confirm the patron phone now has a class, .patronphone 14 - confirm the patron email now has a class, .patronemail, that the class includes the bullet point, and that the #boremail id has been removed 15 - click Confirm Hold 16 - check your item in again, triggering hold-found1 modal 17 - confirm the patron phone now has a class, .patronphone 18 - confirm the patron email now has a class, .patronemail, and that the #boremail id has been removed |