| Summary: | Click on New data provider breaks functionality | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Jan Kissig <bibliothek> |
| Component: | ERM | Assignee: | Jan Kissig <bibliothek> |
| Status: | Passed QA --- | QA Contact: | Kyle M Hall (khall) <kyle> |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | david, jonathan.druart, jonathan.field, lucas, martin.renvoize, matt.blenkinsop, pedro.amorim |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: |
This fixes adding a new data provider after creating a new data provider (ERM > eUsage > Data providers > New data provider).
If you created a new data provider, clicked close after the information about the provider was shown, then went to add another new data provider - nothing happened: you got an empty page, and there was an error in the browser developer tools console.
|
Version(s) released in: | |
| Circulation function: | |||
| Attachments: |
Bug 41120: Fix broken Add data provider functionality
Bug 41120: Fix broken Add data provider functionality Bug 41120: Fix broken Add data provider functionality |
||
|
Description
Jan Kissig
2025-10-28 11:24:57 UTC
Created attachment 188506 [details] [review] Bug 41120: Fix broken Add data provider functionality Clicking on New data provider in the ERM eUsage section will not work, when a data provider was shown before. Test plan: prequisites: - activate the ERM module system preference. - this is for ktd a) go to /cgi-bin/koha/erm/eusage/usage_data_providers b) add a new data provider, dummy data is sufficient c) submit the new provider and on the following screen click close to return to the provider list d) click on 'Add data provider' (open web dev tools will display an error) e) apply patch f) run 'yarn js:build' f) do a hard refresh in the browser g) on provider list click your created provider h) close it via 'close' to return to the provider list d) click on 'Add data provider' should work now alternatively this fix:
in koha3/koha-tmpl/intranet-tmpl/prog/js/vue/modules/erm.ts
The call of navigationStore.$patch includes 'from' but if you log the state of 'from' after the call of $patch it remained as before.
So the following changes the state of from in an extra call.
navigationStore.$patch({
current: to.matched,
params: to.params || {},
});
navigationStore.from = from;
What remains is a warning in Firefox console: [Vue Router warn]: Discarded invalid param(s) "erm_usage_data_provider_id" when navigating. See https://github.com/vuejs/router/blob/main/packages/router/CHANGELOG.md#414-2022-08-22 for more details.
Created attachment 190708 [details] [review] Bug 41120: Fix broken Add data provider functionality Clicking on New data provider in the ERM eUsage section will not work, when a data provider was shown before. Test plan: prequisites: - activate the ERM module system preference. - this is for ktd a) go to /cgi-bin/koha/erm/eusage/usage_data_providers b) add a new data provider, dummy data is sufficient c) submit the new provider and on the following screen click close to return to the provider list d) click on 'Add data provider' (open web dev tools will display an error) e) apply patch f) run 'yarn js:build' f) do a hard refresh in the browser g) on provider list click your created provider h) close it via 'close' to return to the provider list d) click on 'Add data provider' should work now Signed-off-by: David Nind <david@davidnind.com> Created attachment 192278 [details] [review] Bug 41120: Fix broken Add data provider functionality Clicking on New data provider in the ERM eUsage section will not work, when a data provider was shown before. Test plan: prequisites: - activate the ERM module system preference. - this is for ktd a) go to /cgi-bin/koha/erm/eusage/usage_data_providers b) add a new data provider, dummy data is sufficient c) submit the new provider and on the following screen click close to return to the provider list d) click on 'Add data provider' (open web dev tools will display an error) e) apply patch f) run 'yarn js:build' f) do a hard refresh in the browser g) on provider list click your created provider h) close it via 'close' to return to the provider list d) click on 'Add data provider' should work now Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> |