| Summary: | Branch Transfer Limits basic editor allows one to prevent transfers from a library to itself and block related holds | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Andrew Fuerste-Henry <andrew> |
| Component: | Circulation | Assignee: | Nick Clemens (kidclamp) <nick> |
| Status: | Signed Off --- | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | gmcharlt, kyle, nick |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 41131: Don't allow limiting transfers from/to a single branch
Bug 41131: Don't allow limiting transfers from/to a single branch |
||
|
Description
Andrew Fuerste-Henry
2025-10-29 15:05:02 UTC
Created attachment 188561 [details] [review] Bug 41131: Don't allow limiting transfers from/to a single branch We say that you cannot limit transfers internally within a branch, but it seems we do allow you to, and don't show you when we do To test: 1 - Go to Admin->Library transfer limits 2 - On a branches page, uncheck the box for that branch e.g. don't allow FIC to transfer to CPL from CPL 3 - Save 4 - Note the box is still checked 5 - Check the DB SELECT * FROM branch_transfer_limits; 6 - There is a line to/from CPL! 7 - Apply patches 8 - updatedatabase 9 - Repeat 5 - the line is deleted! 10 - Try to create the rule again, not the box is now disabled 11 - Be sneaky, enable the box, uncheck it and save, no rule created 12 - Be sneaky, edit the HMTL for another button to make it limiting CPL to CPL, save, no rule created 13 - Sign off Created attachment 190482 [details] [review] Bug 41131: Don't allow limiting transfers from/to a single branch We say that you cannot limit transfers internally within a branch, but it seems we do allow you to, and don't show you when we do To test: 1 - Go to Admin->Library transfer limits 2 - On a branches page, uncheck the box for that branch e.g. don't allow FIC to transfer to CPL from CPL 3 - Save 4 - Note the box is still checked 5 - Check the DB SELECT * FROM branch_transfer_limits; 6 - There is a line to/from CPL! 7 - Apply patches 8 - updatedatabase 9 - Repeat 5 - the line is deleted! 10 - Try to create the rule again, not the box is now disabled 11 - Be sneaky, enable the box, uncheck it and save, no rule created 12 - Be sneaky, edit the HMTL for another button to make it limiting CPL to CPL, save, no rule created 13 - Sign off Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Works as described. One note about p. 12. No rule where created when I change TPL to CPL in proper checkbox attribute "name". But then rule for TPL was created, probably as effect of compare lists: (1) branches from DB and (2) branches from form. TPL was not present in form (changed to CPL), so TPL (used from list of branches) was treated as "unchecked" => "not allowed" and rule was created. [ branch_transfer_limits.pl line ~70 ] |