| Summary: | "Default checkout, hold and return policy" needs a space in title | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Christopher Brannon <cbrannon> |
| Component: | System Administration | Assignee: | Caroline Cyr La Rose <caroline.cyr-la-rose> |
| Status: | Signed Off --- | QA Contact: | Testopia <testopia> |
| Severity: | trivial | ||
| Priority: | P5 - low | CC: | caroline.cyr-la-rose, david, gmcharlt |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | String patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 41190: Add space in "Default checkout, hold and return policy" title
Bug 41190: Add space in "Default checkout, hold and return policy" title |
||
|
Description
Christopher Brannon
2025-11-05 16:01:43 UTC
Created attachment 190257 [details] [review] Bug 41190: Add space in "Default checkout, hold and return policy" title This patch adds a space in the title "Default checkout, hold and return policy" in the circulation rules page. To test: 1. Go to Administration > Circulation and fine rules 2. Select a library (e.g. Centerville) 3. Scroll down to the second table --> Note the title of the section is "Default checkout, hold and return policyfor Centerville" with a space missing between "policy" and "for" 4. Apply the patch 5. Refresh the page --> The title should now look normal with all the spaces! "Default checkout, hold and return policy for Centerville" I just noticed this and thought it was a mistake in the translation! Easy fix and easy to test. Hopefully, it will go in fast :D Created attachment 190258 [details] [review] Bug 41190: Add space in "Default checkout, hold and return policy" title This patch adds a space in the title "Default checkout, hold and return policy" in the circulation rules page. To test: 1. Go to Administration > Circulation and fine rules 2. Select a library (e.g. Centerville) 3. Scroll down to the second table --> Note the title of the section is "Default checkout, hold and return policyfor Centerville" with a space missing between "policy" and "for" 4. Apply the patch 5. Refresh the page --> The title should now look normal with all the spaces! "Default checkout, hold and return policy for Centerville" Signed-off-by: David Nind <david@davidnind.com> Had an off git error when trying to apply the patch: git bz apply 41190 Bug 41190 - "Default checkout, hold and return policy" needs a space in title 190257 - Bug 41190: Add space in "Default checkout, hold and return policy" title Apply? [(y)es, (n)o, (i)nteractive] y Patch is empty. Ended up editing the file to make the change and then amending the commit. ... 'off' should be 'odd'! Tried signing off and got this via sandbox:
Saved working directory and index state WIP on main: 3f2987eb19 Koha 25.11.00 is here!
/bin/sh: 1: Brannon: not found
fatal: It looks like 'git am' is in progress. Cannot rebase.
On branch main
Your branch is up to date with 'origin/main'.
You are in the middle of an am session.
(fix conflicts and then run "git am --continue")
(use "git am --skip" to skip this patch)
(use "git am --abort" to restore the original branch)
Changes not staged for commit:
(use "git add <file>..." to update what will be committed)
(use "git restore <file>..." to discard changes in working directory)
[31mmodified: koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt[m
no changes added to commit (use "git add" and/or "git commit -a")
Dropped refs/stash@{0} (8322473a76a0270c3b5e3889486191acf550476e)
The patch should apply cleanly now. If you can add your sign-off, then I can do the QA (it's a string patch, and within my capabilities to QA!). (In reply to David Nind from comment #4) > Had an off git error when trying to apply the patch: > > git bz apply 41190 > > Bug 41190 - "Default checkout, hold and return policy" needs a space in title > > 190257 - Bug 41190: Add space in "Default checkout, hold and return policy" > title > > Apply? [(y)es, (n)o, (i)nteractive] y > Patch is empty. > > Ended up editing the file to make the change and then amending the commit. Whoops, sorry! I guess I was feeling too confident even if it was friday afternoon |