| Summary: | Error in Advanced Cataloging editor when z39 source returns undef / empty records | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> |
| Component: | Cataloging | Assignee: | Nick Clemens (kidclamp) <nick> |
| Status: | Pushed to oldstable --- | QA Contact: | Marcel de Rooy <m.de.rooy> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | fridolin.somers, m.de.rooy, phil |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
25.11.00,25.05.06,24.11.11
|
|
| Circulation function: | |||
| Attachments: |
Bug 41205: Skip undef records in Z39 response
Bug 41205: Skip undef records in Z39 response Bug 41205: Skip undef records in Z39 response |
||
Created attachment 189171 [details] [review] Bug 41205: Skip undef records in Z39 response This patch simply skips undefined records - this prevents the error though it doesn't explain why we get undef records here and a Z39 search from standard cataloging just returns nothing. This prevents a breakage of the search. To test: 1 - Have LOC defined as a Z39 Source (standard in KTD) 2 - Open the advanced editor 3 - Search for ISBN 9780520401129 4 - Search explodes, logs like: AH01215: stderr from /kohadevbox/koha/svc/cataloguing/metasearch: Can't call method "raw" on an undefined value at /kohadevbox/koha/Koha/MetaSearcher.pm line 267., referer: http://localhost:8081/cgi-bin/koha/cataloguing/editor.pl AH01215: stderr from /kohadevbox/koha/svc/cataloguing/metasearch: Magic number checking on storable file failed at /usr/lib/x86_64-linux-gnu/perl/5.36/Storable.pm line 443, at /kohadevbox/koha/Koha/MetaSearcher.pm line 144., referer: http://localhost:8081/cgi-bin/koha/cataloguing/editor.pl 5 - Must refresh the page to clear the bad error message 6 - Apply patch 7 - Repeat search - no results, LOC says 'Permanent system error' 8 - You can close the results and do a new search Created attachment 189245 [details] [review] Bug 41205: Skip undef records in Z39 response This patch simply skips undefined records - this prevents the error though it doesn't explain why we get undef records here and a Z39 search from standard cataloging just returns nothing. This prevents a breakage of the search. To test: 1 - Have LOC defined as a Z39 Source (standard in KTD) 2 - Open the advanced editor 3 - Search for ISBN 9780520401129 4 - Search explodes, logs like: AH01215: stderr from /kohadevbox/koha/svc/cataloguing/metasearch: Can't call method "raw" on an undefined value at /kohadevbox/koha/Koha/MetaSearcher.pm line 267., referer: http://localhost:8081/cgi-bin/koha/cataloguing/editor.pl AH01215: stderr from /kohadevbox/koha/svc/cataloguing/metasearch: Magic number checking on storable file failed at /usr/lib/x86_64-linux-gnu/perl/5.36/Storable.pm line 443, at /kohadevbox/koha/Koha/MetaSearcher.pm line 144., referer: http://localhost:8081/cgi-bin/koha/cataloguing/editor.pl 5 - Must refresh the page to clear the bad error message 6 - Apply patch 7 - Repeat search - no results, LOC says 'Permanent system error' 8 - You can close the results and do a new search Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> This looks similar (from Breeding):
if ( $oResult[$k]->record($i) ) {
So looks good.
Created attachment 189253 [details] [review] Bug 41205: Skip undef records in Z39 response This patch simply skips undefined records - this prevents the error though it doesn't explain why we get undef records here and a Z39 search from standard cataloging just returns nothing. This prevents a breakage of the search. To test: 1 - Have LOC defined as a Z39 Source (standard in KTD) 2 - Open the advanced editor 3 - Search for ISBN 9780520401129 4 - Search explodes, logs like: AH01215: stderr from /kohadevbox/koha/svc/cataloguing/metasearch: Can't call method "raw" on an undefined value at /kohadevbox/koha/Koha/MetaSearcher.pm line 267., referer: http://localhost:8081/cgi-bin/koha/cataloguing/editor.pl AH01215: stderr from /kohadevbox/koha/svc/cataloguing/metasearch: Magic number checking on storable file failed at /usr/lib/x86_64-linux-gnu/perl/5.36/Storable.pm line 443, at /kohadevbox/koha/Koha/MetaSearcher.pm line 144., referer: http://localhost:8081/cgi-bin/koha/cataloguing/editor.pl 5 - Must refresh the page to clear the bad error message 6 - Apply patch 7 - Repeat search - no results, LOC says 'Permanent system error' 8 - You can close the results and do a new search Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Nice work everyone! Pushed to main for 25.11 Nice work everyone! Pushed to 25.05.x Pushed to 24.11.x for 24.11.11 |
To recreate: 1 - Have LOC defined as a Z39 Source (standard in KTD) 2 - Open the advanced editor 3 - Search for ISBN 9780520401129 4 - Search explodes, logs like: AH01215: stderr from /kohadevbox/koha/svc/cataloguing/metasearch: Can't call method "raw" on an undefined value at /kohadevbox/koha/Koha/MetaSearcher.pm line 267., referer: http://localhost:8081/cgi-bin/koha/cataloguing/editor.pl AH01215: stderr from /kohadevbox/koha/svc/cataloguing/metasearch: Magic number checking on storable file failed at /usr/lib/x86_64-linux-gnu/perl/5.36/Storable.pm line 443, at /kohadevbox/koha/Koha/MetaSearcher.pm line 144., referer: http://localhost:8081/cgi-bin/koha/cataloguing/editor.pl