Bug 41207

Summary: Permission description string does match permission name
Product: Koha Reporter: Lawrence O'Regan-Lloyd <loreganlloyd>
Component: TemplatesAssignee: Lawrence O'Regan-Lloyd <loreganlloyd>
Status: Pushed to oldstable --- QA Contact: Laura Escamilla <Laura.escamilla>
Severity: trivial    
Priority: P5 - low CC: fridolin.somers, lucas
Version: Main   
Hardware: All   
OS: All   
GIT URL: Initiative type: ---
Sponsorship status: --- Comma delimited list of Sponsors:
Crowdfunding goal: 0 Patch complexity: String patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
25.11.00,25.05.06,24.11.11
Circulation function:
Attachments: Bug 41207: Fix spelling of edit_items suggestion text in edit_catalog subpermission
Bug 41207: Fix spelling of edit_items suggestion text in edit_catalog subpermission
Bug 41207: Fix spelling of edit_items suggestion text in edit_catalog subpermission

Description Lawrence O'Regan-Lloyd 2025-11-06 15:50:36 UTC
On member-flags.pl under the Edit Catalog the description for this subpermission mentions edit_item permission however this should read edit_items. 

To reproduce: 
Go to a patron record
Click on more -> set permissions
Scroll down and expand the Edit Catalog
Notice the line says edit_item is required but the permission needed is edit_items
Comment 1 Lawrence O'Regan-Lloyd 2025-11-06 16:20:03 UTC
Created attachment 189187 [details] [review]
Bug 41207: Fix spelling of edit_items suggestion text in edit_catalog subpermission

This patch fixes the spelling of edit_items in the suggestion text in an edit_catalog subpermission.

Test plan:
0. Go to a patron record
1. Click on more -> set permissions
2. Scroll down and expand the Edit Catalog
3. Notice the line says edit_item is required but the permission needed is edit_items
4. Apply patch
5. Repeat steps 0-3
6. Confirm the suggestion text in the edit_catalog subpermission now reads edit_items

Sponsored-by: CLAMS
Comment 2 Owen Leonard 2025-11-07 12:20:03 UTC
Created attachment 189294 [details] [review]
Bug 41207: Fix spelling of edit_items suggestion text in edit_catalog subpermission

This patch fixes the spelling of edit_items in the suggestion text in
an edit_catalog subpermission.

Test plan:
0. Go to a patron record
1. Click on more -> set permissions
2. Scroll down and expand the Edit Catalog
3. Notice the line says edit_item is required but the permission needed
   is edit_items
4. Apply patch
5. Repeat steps 0-3
6. Confirm the suggestion text in the edit_catalog subpermission now
   reads edit_items

Sponsored-by: CLAMS
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 3 Laura Escamilla 2025-11-07 13:56:46 UTC
Created attachment 189321 [details] [review]
Bug 41207: Fix spelling of edit_items suggestion text in edit_catalog subpermission

This patch fixes the spelling of edit_items in the suggestion text in
an edit_catalog subpermission.

Test plan:
0. Go to a patron record
1. Click on more -> set permissions
2. Scroll down and expand the Edit Catalog
3. Notice the line says edit_item is required but the permission needed
   is edit_items
4. Apply patch
5. Repeat steps 0-3
6. Confirm the suggestion text in the edit_catalog subpermission now
   reads edit_items

Sponsored-by: CLAMS
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com>
Comment 4 Lucas Gass (lukeg) 2025-11-17 22:17:19 UTC
Nice work everyone!

Pushed to main for 25.11
Comment 5 Paul Derscheid 2025-11-25 16:31:43 UTC
Nice work everyone!

Pushed to 25.05.x
Comment 6 Fridolin Somers 2025-12-02 10:53:22 UTC
Pushed to 24.11.x for 24.11.11