Bug 41248

Summary: Add ability for real time holds queue background jobs to skip duplicate jobs
Product: Koha Reporter: Kyle M Hall (khall) <kyle>
Component: Architecture, internals, and plumbingAssignee: Kyle M Hall (khall) <kyle>
Status: Failed QA --- QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low    
Version: 25.05   
Hardware: All   
OS: All   
GIT URL: Initiative type: ---
Sponsorship status: --- Comma delimited list of Sponsors:
Crowdfunding goal: 0 Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:
Attachments: Bug 41248: Add ability for real time holds queue background jobs to skip duplicate jobs (edit)
Bug 41248: Add unit tests
Bug 41248: Add ability for real time holds queue background jobs to skip duplicate jobs
Bug 41248: Add unit tests
Bug 41248: Add ability for real time holds queue background jobs to skip duplicate jobs
Bug 41248: Add unit tests

Description Kyle M Hall (khall) 2025-11-13 14:39:33 UTC
It seems inefficient to rebuild the holds queue repeatedly for the same record. We should skip enqueuing BatchUpdateBiblioHoldsQueue jobs if there is already a queued job that hasn't started.
Comment 1 Kyle M Hall (khall) 2025-11-13 15:29:01 UTC
Created attachment 189567 [details] [review]
Bug 41248: Add ability for real time holds queue background jobs to skip duplicate jobs (edit)

It seems inefficient to rebuild the holds queue repeatedly for the same record. We should skip enqueuing BatchUpdateBiblioHoldsQueue jobs if there is already a queued job that hasn't started.
Test Plan:
1) Enable real time holds queue
2) Ensure the default queue background job worker is not running
3) Set up 2 or more holds for the record
4) Alter the priority for those holds a couple times
5) Confirm only one new job is in the background_jobs table for that
   record.
Comment 2 Kyle M Hall (khall) 2025-11-13 15:29:02 UTC
It seems inefficient to rebuild the holds queue repeatedly for the same record. We should skip enqueuing BatchUpdateBiblioHoldsQueue jobs if there is already a queued job that hasn't started.
Test Plan:
1) Enable real time holds queue
2) Ensure the default queue background job worker is not running
3) Set up 2 or more holds for the record
4) Alter the priority for those holds a couple times
5) Confirm only one new job is in the background_jobs table for that
   record.
Comment 3 Kyle M Hall (khall) 2025-11-13 15:36:24 UTC
Created attachment 189569 [details] [review]
Bug 41248: Add unit tests
Comment 4 Kyle M Hall (khall) 2025-11-13 15:37:13 UTC
Created attachment 189570 [details] [review]
Bug 41248: Add ability for real time holds queue background jobs to skip duplicate jobs

It seems inefficient to rebuild the holds queue repeatedly for the same record. We should skip enqueuing BatchUpdateBiblioHoldsQueue jobs if there is already a queued job that hasn't started.
Test Plan:
1) Enable real time holds queue
2) Ensure the default queue background job worker is not running
3) Set up 2 or more holds for the record
4) Alter the priority for those holds a couple times
5) Confirm only one new job is in the background_jobs table for that
   record.
Comment 5 Kyle M Hall (khall) 2025-11-13 15:37:14 UTC
Created attachment 189571 [details] [review]
Bug 41248: Add unit tests

Patch from commit fadb037
Comment 6 Kyle M Hall (khall) 2025-11-13 15:37:16 UTC
It seems inefficient to rebuild the holds queue repeatedly for the same record. We should skip enqueuing BatchUpdateBiblioHoldsQueue jobs if there is already a queued job that hasn't started.
Test Plan:
1) Enable real time holds queue
2) Ensure the default queue background job worker is not running
3) Set up 2 or more holds for the record
4) Alter the priority for those holds a couple times
5) Confirm only one new job is in the background_jobs table for that
   record.
Comment 7 Lucas Gass (lukeg) 2025-11-13 18:41:43 UTC
Created attachment 189581 [details] [review]
Bug 41248: Add ability for real time holds queue background jobs to skip duplicate jobs

It seems inefficient to rebuild the holds queue repeatedly for the same record. We should skip enqueuing BatchUpdateBiblioHoldsQueue jobs if there is already a queued job that hasn't started.

Test Plan:
1) Enable real time holds queue
2) Ensure the default queue background job worker is not running
3) Set up 2 or more holds for the record
4) Alter the priority for those holds a couple times
5) Confirm only one new job is in the background_jobs table for that
   record.

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 8 Lucas Gass (lukeg) 2025-11-13 18:41:45 UTC
Created attachment 189582 [details] [review]
Bug 41248: Add unit tests

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 9 Kyle M Hall (khall) 2025-11-13 19:52:44 UTC
Failing QA until supply a follow-up patch to add an index to background_jobs.data. On a server with 762052 background_jobs entries, the queries take over 1.5 seconds each, which seems like a long time to me.