| Summary: | The filter for item status in item tables should be improved | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Mathieu Saby <mathsabypro> |
| Component: | Staff interface | Assignee: | Jonathan Druart <jonathan.druart> |
| Status: | Signed Off --- | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | david, fridolin.somers, gmcharlt, jonathan.druart, mspinney, oleonard |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: |
This enhancement groups the values for the records detail page status column filter on the holdings table in the staff interface.
This makes it easier to select the appropriate status value, as it can correspond to multiple authorised values, for example, Not for loan, Withdrawn, Lost and Damaged. Until now, only a single entry could be selected, and filtering applied to all values at once.
|
Version(s) released in: | |
| Circulation function: | |||
| Bug Depends on: | 37334 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 41254: Allow filtering by all authorised values for multi-valued statuses
Bug 41254: Replace '*' with arrow Bug 41254: Add '(all)' for top-level entries Bug 41254: Allow filtering by all authorised values for multi-valued statuses Bug 41254: Replace '*' with arrow Bug 41254: Add '(all)' for top-level entries Bug 41254: Allow filtering by all authorised values for multi-valued statuses Bug 41254: Replace '*' with arrow Bug 41254: Add '(all)' for top-level entries |
||
|
Description
Mathieu Saby
2025-11-16 18:40:20 UTC
Or create a new column for "not for loan" ? Not sure... The table is already very wide (and Koha handles this poorly in terms of UX, with screen overflow), and we've just added a new column for locations. Created attachment 189928 [details] [review] Bug 41254: Allow filtering by all authorised values for multi-valued statuses Some item statuses can correspond to multiple authorised values: Not for loan, Withdrawn, Lost and Damaged. Until now, only a single entry could be selected, and filtering applied to all values at once. This change introduces finer-grained filtering by exposing each authorised value individually in the filter. Test plan: Assign multiple authorised values to items on a bibliographic record for the four affected attributes: Not for loan, Withdrawn, Lost and Damaged. Use the "Status" filter and verify that each value behaves as expected. Display note: The current dropdown presentation is not ideal. Suggestions for improvement are welcome, although avoiding optgroup would be preferable to keep the scope small. Thank you! I tested on a sandbox, it works fine. Maybe "* " could be replaced with "> " ? Not sure what would be the best "* Not for loan" (based on itemtype I guess?) in "Not for loan" category is weird, but it is Koha's terminology. Maybe we could rephrase it a bit, like "Not for loan itemtype" ? Of course the list is very long, but libraries can easily hide unwanted options in the list with CSS or JS (we did it, I don't remember how but it was not difficult) (In reply to Mathieu Saby from comment #5) > Thank you! > I tested on a sandbox, it works fine. > Maybe "* " could be replaced with "> " ? Not sure what would be the best I think we should either wait for QA or for more feedback once it's pushed. > "* Not for loan" (based on itemtype I guess?) in "Not for loan" category is > weird, but it is Koha's terminology. Maybe we could rephrase it a bit, like > "Not for loan itemtype" ? Or with '(all)' maybe? Owen, any good ideas here? Created attachment 190051 [details] [review] Bug 41254: Replace '*' with arrow Patch from commit 6e15e99 Created attachment 190052 [details] [review] Bug 41254: Add '(all)' for top-level entries Patch from commit 88a4aa8 (In reply to Jonathan Druart from comment #4) > https://snipboard.io/4lIdgx.jpg And with the last 2 patches: https://snipboard.io/4rDpCB.jpg The patches no longer apply 8-(... git bz apply 41254 Bug 41254 - The filter for item status in item tables should be improved 189928 - Bug 41254: Allow filtering by all authorised values for multi-valued statuses 190051 - Bug 41254: Replace '*' with arrow 190052 - Bug 41254: Add '(all)' for top-level entries Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 41254: Allow filtering by all authorised values for multi-valued statuses Using index info to reconstruct a base tree... M Koha/Items.pm M koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers/tables/items/catalogue_detail.inc M t/db_dependent/Koha/Items.t Falling back to patching base and 3-way merge... Auto-merging t/db_dependent/Koha/Items.t Auto-merging koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers/tables/items/catalogue_detail.inc CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers/tables/items/catalogue_detail.inc Auto-merging Koha/Items.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 41254: Allow filtering by all authorised values for multi-valued statuses Created attachment 190345 [details] [review] Bug 41254: Allow filtering by all authorised values for multi-valued statuses Some item statuses can correspond to multiple authorised values: Not for loan, Withdrawn, Lost and Damaged. Until now, only a single entry could be selected, and filtering applied to all values at once. This change introduces finer-grained filtering by exposing each authorised value individually in the filter. Test plan: Assign multiple authorised values to items on a bibliographic record for the four affected attributes: Not for loan, Withdrawn, Lost and Damaged. Use the "Status" filter and verify that each value behaves as expected. Display note: The current dropdown presentation is not ideal. Suggestions for improvement are welcome, although avoiding optgroup would be preferable to keep the scope small. Created attachment 190346 [details] [review] Bug 41254: Replace '*' with arrow Patch from commit 29ba30f Created attachment 190347 [details] [review] Bug 41254: Add '(all)' for top-level entries Patch from commit 0f0897f Created attachment 190427 [details] [review] Bug 41254: Allow filtering by all authorised values for multi-valued statuses Some item statuses can correspond to multiple authorised values: Not for loan, Withdrawn, Lost and Damaged. Until now, only a single entry could be selected, and filtering applied to all values at once. This change introduces finer-grained filtering by exposing each authorised value individually in the filter. Test plan: Assign multiple authorised values to items on a bibliographic record for the four affected attributes: Not for loan, Withdrawn, Lost and Damaged. Use the "Status" filter and verify that each value behaves as expected. Display note: The current dropdown presentation is not ideal. Suggestions for improvement are welcome, although avoiding optgroup would be preferable to keep the scope small. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 190428 [details] [review] Bug 41254: Replace '*' with arrow Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 190429 [details] [review] Bug 41254: Add '(all)' for top-level entries Signed-off-by: Owen Leonard <oleonard@myacpl.org> |