Bug 41280

Summary: Adjust PatronLibrary scope, respect global level for the second patron_maxissueqty rule in C4::Circulation::TooMany
Product: Koha Reporter: Marcel de Rooy <m.de.rooy>
Component: CirculationAssignee: Marcel de Rooy <m.de.rooy>
Status: ASSIGNED --- QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: gmcharlt, kyle, martin.renvoize, nick
Version: Main   
Hardware: All   
OS: All   
GIT URL: Initiative type: ---
Sponsorship status: --- Comma delimited list of Sponsors:
Crowdfunding goal: 0 Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:
Attachments: Bug 41280: Add check on branchcode of patron_maxissueqty rule
Bug 41280: Add patron library scope to PatronLibrary for branch level rules
Bug 41280: Add check on branchcode of patron_maxissueqty rule
Bug 41280: Add patron library scope to PatronLibrary for branch level rules

Description Marcel de Rooy 2025-11-21 09:42:19 UTC
See bug 27834. Thinking here about an alternative approach (without messing up the original report).
Comment 1 Marcel de Rooy 2025-11-21 10:09:19 UTC
Created attachment 189836 [details] [review]
Bug 41280: Add check on branchcode of patron_maxissueqty rule

Test plan:
Still coming
Comment 2 Marcel de Rooy 2025-11-21 10:42:29 UTC
Created attachment 189837 [details] [review]
Bug 41280: Add patron library scope to PatronLibrary for branch level rules

At the same time bringing both CircControl blocks more in sync by using
$branch and a new $prefetch variable.
Comment 3 Marcel de Rooy 2025-11-21 11:13:14 UTC
Created attachment 189838 [details] [review]
Bug 41280: Add check on branchcode of patron_maxissueqty rule

Test plan:
Still coming
Comment 4 Marcel de Rooy 2025-11-21 11:13:15 UTC
Created attachment 189839 [details] [review]
Bug 41280: Add patron library scope to PatronLibrary for branch level rules

At the same time bringing both CircControl blocks more in sync by using
$branch and a new $prefetch variable.
Comment 5 Marcel de Rooy 2025-11-21 11:13:36 UTC
Fixed: Can't call method "branchcode" on unblessed reference at /usr/share/koha/C4/Circulation.pm line 594