| Summary: | Error in preservation module breadcrumb | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Tomás Cohen Arazi (tcohen) <tomascohen> |
| Component: | Preservation | Assignee: | Tomás Cohen Arazi (tcohen) <tomascohen> |
| Status: | Signed Off --- | QA Contact: | Testopia <testopia> |
| Severity: | blocker | ||
| Priority: | P5 - low | CC: | jonathan.druart, lucas, martin.renvoize, tomascohen |
| Version: | unspecified | Keywords: | rel_25_11_candidate |
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 41364: Fix error in preservation module breadcrumb
Bug 41364: Fix error in preservation module breadcrumb |
||
|
Description
Tomás Cohen Arazi (tcohen)
2025-12-03 15:43:01 UTC
Created attachment 190122 [details] [review] Bug 41364: Fix error in preservation module breadcrumb This patch makes the 'Processings' breadcrum element not be tied to a component but a plain string with the link disabled. This was causing errors: - Breadcrumb element empty - Error in the browser console To test: 1. Enable the Preservation module 2. Go to Home > Preservation > Settings 3. Use the 'Add a new processing' button => FAIL: The breadcrumb has 'Settings > > Add processing' (i.e. is missing 'Processings' between >) 4. Click on 'Edit this processing' => FAIL: Same error, different context 5. Check the browser console => FAIL: You see something like this: ``` [Vue Router warn]: No match found for location with path "/cgi-bin/koha/preservation/settings/processings" devtools-BLCumUwL.mjs:59:1 ``` 6. Run the cypress tests for this module: k$ run_cypress --spec t/cypress/integration/Preservation/Settings.ts => FAIL: The breadcrumb navigation is broken 7. Apply this patch 8. Rebuild things: $ ktd --shell k$ yarn build 9. Fully refresh the page (Use cmd+shift+r on macOS, ctrl+shift+r on Linux/Windows) 10. Repeat 2-6 => SUCCESS: The breadcrumb is no longer broken => SUCCESS: No errors/warnings about this in the browser console => SUCCESS: Tests pass! 11. Sign off :-D Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> Created attachment 190124 [details] [review] Bug 41364: Fix error in preservation module breadcrumb This patch makes the 'Processings' breadcrum element not be tied to a component but a plain string with the link disabled. This was causing errors: - Breadcrumb element empty - Error in the browser console To test: 1. Enable the Preservation module 2. Go to Home > Preservation > Settings 3. Use the 'Add a new processing' button => FAIL: The breadcrumb has 'Settings > > Add processing' (i.e. is missing 'Processings' between >) 4. Click on 'Edit this processing' => FAIL: Same error, different context 5. Check the browser console => FAIL: You see something like this: ``` [Vue Router warn]: No match found for location with path "/cgi-bin/koha/preservation/settings/processings" devtools-BLCumUwL.mjs:59:1 ``` 6. Run the cypress tests for this module: k$ run_cypress --spec t/cypress/integration/Preservation/Settings.ts => FAIL: The breadcrumb navigation is broken 7. Apply this patch 8. Rebuild things: $ ktd --shell k$ yarn build 9. Fully refresh the page (Use cmd+shift+r on macOS, ctrl+shift+r on Linux/Windows) 10. Repeat 2-6 => SUCCESS: The breadcrumb is no longer broken => SUCCESS: No errors/warnings about this in the browser console => SUCCESS: Tests pass! 11. Sign off :-D Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> |