| Summary: | Do not hide all items if there is a pref OpacMaxItemsToDisplay | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski> |
| Component: | OPAC | Assignee: | Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski> |
| Status: | Signed Off --- | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | david |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: |
This fixes the number of items shown for a record in the OPAC when OpacMaxItemsToDisplay is used. It should only show the number of items in the system preference. Instead, it was showing no items if the number was reached.
Example: With a record that has four items and OpacMaxItemsToDisplay set to three, no items were shown and you had to click "View all the physical items". Now it works as expected, three items are shown and you click "View all the physical items" to see all four items.
|
Version(s) released in: | |
| Circulation function: | |||
| Attachments: |
Bug 41402: Do not hide all items if there is a pref OpacMaxItemsToDisplay
Bug 41402: Do not hide all items if there is a pref OpacMaxItemsToDisplay Bug 41402: Do not hide all items if there is a pref OpacMaxItemsToDisplay |
||
|
Description
Baptiste Wojtkowski (bwoj)
2025-12-08 15:32:04 UTC
Created attachment 190288 [details] [review] Bug 41402: Do not hide all items if there is a pref OpacMaxItemsToDisplay Test plan: 1. Set OpacMaxItemsToDisplay to 3. 2. Add multiple items on a record. 3. Visit http://koha-ktd:8080/cgi-bin/koha/opac-detail.pl?biblionumber=YOUR_BIBLIONUMBER, notice every items are hidden. 4. Apply patch 5. Visit the same page, notice that the 3 first items are displayed Note : From a technical point of view, there is no real change concerning the load. All items were formerly fetched and none were processed. Now, all items are still fetched and OpacMaxItemsToDisplay are processed, which is supposed to be low enough to guarantee correct response time. Created attachment 190314 [details] [review] Bug 41402: Do not hide all items if there is a pref OpacMaxItemsToDisplay Test plan: 1. Set OpacMaxItemsToDisplay to 3. 2. Add multiple items on a record. 3. Visit http://koha-ktd:8080/cgi-bin/koha/opac-detail.pl?biblionumber=YOUR_BIBLIONUMBER, notice every items are hidden. 4. Apply patch 5. Visit the same page, notice that the 3 first items are displayed Signed-off-by: David Nind <you@example.com> Changed bug from an enhancement to normal (as it is a bug), also changed the assignee. Created attachment 190321 [details] [review] Bug 41402: Do not hide all items if there is a pref OpacMaxItemsToDisplay Test plan: 1. Set OpacMaxItemsToDisplay to 3. 2. Add multiple items on a record. 3. Visit http://koha-ktd:8080/cgi-bin/koha/opac-detail.pl?biblionumber=YOUR_BIBLIONUMBER, notice every items are hidden. 4. Apply patch 5. Visit the same page, notice that the 3 first items are displayed Signed-off-by: David Nind <david@davidnind.com> My sign-off line was incorrect, so have updated. |