| Summary: | POS Inline Editing Triggers Form Submission on Enter Key | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Martin Renvoize (ashimema) <martin.renvoize> |
| Component: | Point of Sale | Assignee: | Martin Renvoize (ashimema) <martin.renvoize> |
| Status: | Pushed to stable --- | QA Contact: | Laura Escamilla <Laura.escamilla> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | david, Laura.escamilla, martin.renvoize, me |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: |
Inline editing the cost or quantity fields on a point of sale transaction, then pressing enter, incorrectly submitted the form--instead of just updating the field.
Now, the values in the fields are updated without submitting the form, and you can continue entering sale details and completing the transaction.
|
Version(s) released in: |
26.05.00,25.11.01
|
| Circulation function: | |||
| Attachments: |
Bug 41408: Added e.preventDefault() and e.stopPropagation() to edit
Bug 41408: Added e.preventDefault() and e.stopPropagation() to edit Bug 41408: Added e.preventDefault() and e.stopPropagation() to edit |
||
|
Description
Martin Renvoize (ashimema)
2025-12-09 15:33:31 UTC
Created attachment 190352 [details] [review] Bug 41408: Added e.preventDefault() and e.stopPropagation() to edit Prevent inline editing in POS for the cost and quantity fields from submitting the form on 'Enter'. Test plan: 1. Ensure the POS page is accessible (Set UsePointOfSale, add a Cash Register and some Debit types for sale) 2. Navigate to the Point of Sale page (pos/pay.pl) 3. Add an item to the "This sale" table 4. Click on the "Cost" cell to edit the price inline 5. Change the value and press Enter 6. Expected: The cell value should update without submitting the form 7. Try editing the "Quantity" field as well (same fix applies) 8. Complete a normal transaction to ensure form submission still works with the submit button Created attachment 190486 [details] [review] Bug 41408: Added e.preventDefault() and e.stopPropagation() to edit Prevent inline editing in POS for the cost and quantity fields from submitting the form on 'Enter'. Test plan: 1. Ensure the POS page is accessible (Set UsePointOfSale, add a Cash Register and some Debit types for sale) 2. Navigate to the Point of Sale page (pos/pay.pl) 3. Add an item to the "This sale" table 4. Click on the "Cost" cell to edit the price inline 5. Change the value and press Enter 6. Expected: The cell value should update without submitting the form 7. Try editing the "Quantity" field as well (same fix applies) 8. Complete a normal transaction to ensure form submission still works with the submit button Signed-off-by: David Nind <david@davidnind.com> Created attachment 190666 [details] [review] Bug 41408: Added e.preventDefault() and e.stopPropagation() to edit Prevent inline editing in POS for the cost and quantity fields from submitting the form on 'Enter'. Test plan: 1. Ensure the POS page is accessible (Set UsePointOfSale, add a Cash Register and some Debit types for sale) 2. Navigate to the Point of Sale page (pos/pay.pl) 3. Add an item to the "This sale" table 4. Click on the "Cost" cell to edit the price inline 5. Change the value and press Enter 6. Expected: The cell value should update without submitting the form 7. Try editing the "Quantity" field as well (same fix applies) 8. Complete a normal transaction to ensure form submission still works with the submit button Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> Nice work everyone! Pushed to main for 26.05 Thanks all, pushed to 25.11.x |