Bug 41428

Summary: validate_isbn.pl value builder contains untranslatable strings
Product: Koha Reporter: Katrin Fischer <katrin.fischer>
Component: I18N/L10NAssignee: Bugs List <koha-bugs>
Status: NEW --- QA Contact: Testopia <testopia>
Severity: minor    
Priority: P5 - low CC: f.demians, jonathan.druart
Version: Main   
Hardware: All   
OS: All   
GIT URL: Initiative type: ---
Sponsorship status: --- Comma delimited list of Sponsors:
Crowdfunding goal: 0 Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:
Bug Depends on: 29980    
Bug Blocks:    

Description Katrin Fischer 2025-12-10 20:16:14 UTC
"Invalid ISBN" alert of  is not translatable.
Comment 1 Owen Leonard 2025-12-11 13:44:13 UTC
We have several instances of "alert()" in .pl files:

opac/opac-tags.pl:
    "window.alert('Your CGI sessio...
cataloguing/value_builder/unimarc_leader.pl:
    alert(_('leader has an incorre...
cataloguing/value_builder/validate_isbn.pl:
    alert("Invalid ISBN : " + isbn...
cataloguing/value_builder/unimarc_field_100.pl:
    alert('error when getting '+i)...
cataloguing/value_builder/unimarc_leader_authorities.pl:
    alert('error when getting '+ev...
cataloguing/value_builder/unimarc_field_100_authorities.pl:
    alert('error when getting '+i)...
cataloguing/value_builder/dateaccessioned.pl:
    if (! id) { alert(_("Bad id ")...
cataloguing/value_builder/unimarc_field_115a.pl:
    alert('error when getting '+i)...
tags/review.pl:
    "window.alert('Your CGI sessio...

Is there a correct way to handle these in cases where there is no template?
Comment 2 Jonathan Druart 2025-12-11 14:15:33 UTC
Koha::I18N::__()