| Summary: | Useless (and confusing) id attribute on a couple of script tag | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
| Component: | Architecture, internals, and plumbing | Assignee: | Jonathan Druart <jonathan.druart> |
| Status: | Signed Off --- | QA Contact: | Testopia <testopia> |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | david |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | |||
| Bug Blocks: | 41566, 41572 | ||
| Attachments: |
Bug 41560: Remove id="js" from script tags
Bug 41560: Remove id="js" from script tags |
||
|
Description
Jonathan Druart
2026-01-09 13:09:31 UTC
Created attachment 191060 [details] [review] Bug 41560: Remove id="js" from script tags Both files koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/issuehistory.tt koha-tmpl/intranet-tmpl/prog/en/modules/members/readingrec.tt have <script id="js"> That's not needed, useless, and confusing. Added from those commits for no obvious reasons catalogue/issuehistory.tt commit df98c8aaaaf0a7406dc24f4c288c8f930aa8215d CommitDate: Mon May 14 15:39:44 2012 +0200 bug_7647: Table sorter on issue history members/readingrec.tt commit 77b6409802e6ce5612883ec6d22db9545547444a CommitDate: Mon Mar 21 20:02:15 2011 +1300 Bug 5917 : Converted templates Created attachment 191229 [details] [review] Bug 41560: Remove id="js" from script tags Both files koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/issuehistory.tt koha-tmpl/intranet-tmpl/prog/en/modules/members/readingrec.tt have <script id="js"> That's not needed, useless, and confusing. Added from those commits for no obvious reasons catalogue/issuehistory.tt commit df98c8aaaaf0a7406dc24f4c288c8f930aa8215d CommitDate: Mon May 14 15:39:44 2012 +0200 bug_7647: Table sorter on issue history members/readingrec.tt commit 77b6409802e6ce5612883ec6d22db9545547444a CommitDate: Mon Mar 21 20:02:15 2011 +1300 Bug 5917 : Converted templates Testing notes (using KTD): 1. I accessed the changed pages before and after the patch. There were no JavaScript errors and the pages worked as expected. 1. Check out two items to a patron and then check in one of the items. 2. From the record's page in the staff interface, view the 'Checkout history' page. 3. From the patron's record in the staff interface, view the 'Circulation history' page. |