Bug 41580

Summary: Tidy kohaTable block - tools
Product: Koha Reporter: Jonathan Druart <jonathan.druart>
Component: TemplatesAssignee: Jonathan Druart <jonathan.druart>
Status: Signed Off --- QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low    
Version: unspecified   
Hardware: All   
OS: All   
GIT URL: Initiative type: ---
Sponsorship status: --- Comma delimited list of Sponsors:
Crowdfunding goal: 0 Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:
Bug Depends on: 39715, 41562    
Bug Blocks: 41324    
Attachments: Bug 41580: Tidy kohaTable - tools/batch_delete_records.tt
Bug 41580: Tidy kohaTable - tools/batch_modify_holds.tt
Bug 41580: Tidy kohaTable - tools/batch_record_modification.tt
Bug 41580: Tidy kohaTable - tools/holidays.tt
Bug 41580: Tidy kohaTable - tools/inventory.tt
Bug 41580: Tidy kohaTable - tools/manage-marc-import.tt
Bug 41580: Tidy kohaTable - tools/modborrowers.tt
Bug 41580: Tidy kohaTable - tools/upload.tt
Bug 41580: tools - auto tidy
Bug 41580: Tidy kohaTable - tools/batch_delete_records.tt
Bug 41580: Tidy kohaTable - tools/batch_modify_holds.tt
Bug 41580: Tidy kohaTable - tools/batch_record_modification.tt
Bug 41580: Tidy kohaTable - tools/holidays.tt
Bug 41580: Tidy kohaTable - tools/inventory.tt
Bug 41580: Tidy kohaTable - tools/manage-marc-import.tt
Bug 41580: Tidy kohaTable - tools/modborrowers.tt
Bug 41580: Tidy kohaTable - tools/upload.tt
Bug 41580: tools - auto tidy
Bug 41580: (follow-up) Fixes for errors
Bug 41580: (follow-up) More tidy

Description Jonathan Druart 2026-01-09 13:58:12 UTC

    
Comment 1 Jonathan Druart 2026-01-09 14:53:36 UTC
Created attachment 191163 [details] [review]
Bug 41580: Tidy kohaTable - tools/batch_delete_records.tt

Patch from commit 4cc3cd0
Comment 2 Jonathan Druart 2026-01-09 14:53:37 UTC
Created attachment 191164 [details] [review]
Bug 41580: Tidy kohaTable - tools/batch_modify_holds.tt

Patch from commit 4e7b21d
Comment 3 Jonathan Druart 2026-01-09 14:53:38 UTC
Created attachment 191165 [details] [review]
Bug 41580: Tidy kohaTable - tools/batch_record_modification.tt

Patch from commit a8cd9fe
Comment 4 Jonathan Druart 2026-01-09 14:53:39 UTC
Created attachment 191166 [details] [review]
Bug 41580: Tidy kohaTable - tools/holidays.tt

Patch from commit 1767e13
Comment 5 Jonathan Druart 2026-01-09 14:53:41 UTC
Created attachment 191167 [details] [review]
Bug 41580: Tidy kohaTable - tools/inventory.tt

Patch from commit b87b416
Comment 6 Jonathan Druart 2026-01-09 14:53:42 UTC
Created attachment 191168 [details] [review]
Bug 41580: Tidy kohaTable - tools/manage-marc-import.tt

Patch from commit 54a27c1
Comment 7 Jonathan Druart 2026-01-09 14:53:43 UTC
Created attachment 191169 [details] [review]
Bug 41580: Tidy kohaTable - tools/modborrowers.tt

Patch from commit c175ba8
Comment 8 Jonathan Druart 2026-01-09 14:53:44 UTC
Created attachment 191170 [details] [review]
Bug 41580: Tidy kohaTable - tools/upload.tt

Patch from commit 0c45d77
Comment 9 Jonathan Druart 2026-01-09 14:53:46 UTC
Created attachment 191171 [details] [review]
Bug 41580: tools - auto tidy

Patch from commit 52c6b50
Comment 10 Owen Leonard 2026-01-20 15:25:50 UTC
Created attachment 191697 [details] [review]
Bug 41580: Tidy kohaTable - tools/batch_delete_records.tt

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 11 Owen Leonard 2026-01-20 15:25:52 UTC
Created attachment 191698 [details] [review]
Bug 41580: Tidy kohaTable - tools/batch_modify_holds.tt

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 12 Owen Leonard 2026-01-20 15:25:55 UTC
Created attachment 191699 [details] [review]
Bug 41580: Tidy kohaTable - tools/batch_record_modification.tt

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 13 Owen Leonard 2026-01-20 15:25:57 UTC
Created attachment 191700 [details] [review]
Bug 41580: Tidy kohaTable - tools/holidays.tt

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 14 Owen Leonard 2026-01-20 15:25:59 UTC
Created attachment 191701 [details] [review]
Bug 41580: Tidy kohaTable - tools/inventory.tt

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 15 Owen Leonard 2026-01-20 15:26:02 UTC
Created attachment 191702 [details] [review]
Bug 41580: Tidy kohaTable - tools/manage-marc-import.tt

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 16 Owen Leonard 2026-01-20 15:26:04 UTC
Created attachment 191703 [details] [review]
Bug 41580: Tidy kohaTable - tools/modborrowers.tt

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 17 Owen Leonard 2026-01-20 15:26:07 UTC
Created attachment 191704 [details] [review]
Bug 41580: Tidy kohaTable - tools/upload.tt

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 18 Owen Leonard 2026-01-20 15:26:09 UTC
Created attachment 191705 [details] [review]
Bug 41580: tools - auto tidy

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 19 Owen Leonard 2026-01-20 15:26:12 UTC
Created attachment 191706 [details] [review]
Bug 41580: (follow-up) Fixes for errors

- In Cataloging -> Manage staged MARC records: the logic around showing
  the "Edit" button was not correct
- In Tools -> Batch patron modification: There was sometimes an error in
  the console about a variable not existing which can be resolved by
  moving the corresponding (and related) JS into the conditional which
  depends on the table of results existing.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 20 Owen Leonard 2026-01-20 15:26:14 UTC
Created attachment 191707 [details] [review]
Bug 41580: (follow-up) More tidy

Signed-off-by: Owen Leonard <oleonard@myacpl.org>