| Summary: | notices_content hook is not checking if individual plugins are enabled and is reloading plugins | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> |
| Component: | Plugin architecture | Assignee: | Tomás Cohen Arazi (tcohen) <tomascohen> |
| Status: | Signed Off --- | QA Contact: | Testopia <testopia> |
| Severity: | major | ||
| Priority: | P5 - low | CC: | Chip.Halvorsen, martin.renvoize, nick, tomascohen |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38384 | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 41684: Make `notices_content` hook be used with `get_enabled_plugins()`
Bug 41684: Make `notices_content` hook be used with `get_enabled_plugins()` |
||
|
Description
Nick Clemens (kidclamp)
2026-01-22 12:43:26 UTC
Created attachment 191885 [details] [review] Bug 41684: Make `notices_content` hook be used with `get_enabled_plugins()` This patch makes the plugin hook load plugins using `get_enabled_plugins()`. This has the immediate effect of using the already cached plugin objects without reinstantiating them. This way transactions don't get broken for schema reloads. Also, only enabled plugins are loaded/attempted to be loaded. To test: 1. Run: $ ktd --shell k$ prove t/db_dependent/Koha/Plugins/Notices_content_hook.t => SUCCESS: Tests pass 2. Apply this patch 3. Repeat 1 => SUCCESS: Tests still pass: fundamental behavior remains unchanged. 4. Sign off :-D Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> Created attachment 191892 [details] [review] Bug 41684: Make `notices_content` hook be used with `get_enabled_plugins()` This patch makes the plugin hook load plugins using `get_enabled_plugins()`. This has the immediate effect of using the already cached plugin objects without reinstantiating them. This way transactions don't get broken for schema reloads. Also, only enabled plugins are loaded/attempted to be loaded. To test: 1. Run: $ ktd --shell k$ prove t/db_dependent/Koha/Plugins/Notices_content_hook.t => SUCCESS: Tests pass 2. Apply this patch 3. Repeat 1 => SUCCESS: Tests still pass: fundamental behavior remains unchanged. 4. Sign off :-D Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> |