Bug 41700

Summary: Checkouts note_date has incorrect format in swagger definitions
Product: Koha Reporter: Nick Clemens (kidclamp) <nick>
Component: REST APIAssignee: Nick Clemens (kidclamp) <nick>
Status: Pushed to main --- QA Contact: Tomás Cohen Arazi (tcohen) <tomascohen>
Severity: normal    
Priority: P5 - low CC: lucas, tomascohen
Version: MainKeywords: rel_25_11_candidate
Hardware: All   
OS: All   
GIT URL: Initiative type: ---
Sponsorship status: --- Comma delimited list of Sponsors:
Crowdfunding goal: 0 Crowdfunding committed: 0
Crowdfunding contact: Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
26.05.00
Circulation function:
Attachments: Bug 41700: Update note_date to datetime
Bug 41700: Unit test
Bug 41700: Update note_date to datetime
Bug 41700: Unit test
Bug 41700: Update note_date to datetime
Bug 41700: Unit test
Bug 41700: Update note_date to datetime
Bug 41700: Unit test

Description Nick Clemens (kidclamp) 2026-01-23 19:44:39 UTC
note_date is defined as 'date' in checkout.yaml
in the issues table it is a datetime. This is causing errors

To recreate:
1 - Enable issue notes:  AllowCheckoutNotes preference
2 - Issue an item to a patron
3 - Sign in to opac as that patron, add a note
4 - Have staff client open and a second tab try:
    http://localhost:8081/api/v1/checkouts/
5 - Error "message":"Does not match date format.","path":"\/body\/0\/note_date"
Comment 1 Nick Clemens (kidclamp) 2026-01-23 19:55:35 UTC
Created attachment 191985 [details] [review]
Bug 41700: Update note_date to datetime

This patch updates the swaager definition to have the correct format

To test:
1 - Enable issue notes:  AllowCheckoutNotes preference
2 - Issue an item to a patron
3 - Sign in to opac as that patron, add a note
4 - Have staff client open and a second tab try:
    http://localhost:8081/api/v1/checkouts/
5 - Error "message":"Does not match date format.","path":"\/body\/0\/note_date"
6 - Apply patch, yarn build, restart all
7 - Refresh the page
8 - Success!
Comment 2 Nick Clemens (kidclamp) 2026-01-23 19:55:38 UTC
Created attachment 191986 [details] [review]
Bug 41700: Unit test
Comment 3 Nick Clemens (kidclamp) 2026-01-23 19:55:59 UTC
Created attachment 191987 [details] [review]
Bug 41700: Update note_date to datetime

This patch updates the swaager definition to have the correct format

To test:
1 - Enable issue notes:  AllowCheckoutNotes preference
2 - Issue an item to a patron
3 - Sign in to opac as that patron, add a note
4 - Have staff client open and a second tab try:
    http://localhost:8081/api/v1/checkouts/
5 - Error "message":"Does not match date format.","path":"\/body\/0\/note_date"
6 - Apply patch, yarn build, restart all
7 - Refresh the page
8 - Success!

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 4 Nick Clemens (kidclamp) 2026-01-23 19:56:01 UTC
Created attachment 191988 [details] [review]
Bug 41700: Unit test

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 5 Nick Clemens (kidclamp) 2026-01-23 19:56:22 UTC
Trivial, but far reaching self SO
Comment 6 Tomás Cohen Arazi (tcohen) 2026-01-26 13:59:03 UTC
Created attachment 192029 [details] [review]
Bug 41700: Update note_date to datetime

This patch updates the swaager definition to have the correct format

To test:
1 - Enable issue notes:  AllowCheckoutNotes preference
2 - Issue an item to a patron
3 - Sign in to opac as that patron, add a note
4 - Have staff client open and a second tab try:
    http://localhost:8081/api/v1/checkouts/
5 - Error "message":"Does not match date format.","path":"\/body\/0\/note_date"
6 - Apply patch, yarn build, restart all
7 - Refresh the page
8 - Success!

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io>
Comment 7 Tomás Cohen Arazi (tcohen) 2026-01-26 13:59:04 UTC
Created attachment 192030 [details] [review]
Bug 41700: Unit test

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io>
Comment 8 Tomás Cohen Arazi (tcohen) 2026-01-26 13:59:30 UTC
Trivial fix, QA script happy, tests pass.

Thanks, Nick!
Comment 9 Lucas Gass (lukeg) 2026-01-28 21:07:07 UTC
Created attachment 192135 [details] [review]
Bug 41700: Update note_date to datetime

This patch updates the swaager definition to have the correct format

To test:
1 - Enable issue notes:  AllowCheckoutNotes preference
2 - Issue an item to a patron
3 - Sign in to opac as that patron, add a note
4 - Have staff client open and a second tab try:
    http://localhost:8081/api/v1/checkouts/
5 - Error "message":"Does not match date format.","path":"\/body\/0\/note_date"
6 - Apply patch, yarn build, restart all
7 - Refresh the page
8 - Success!

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io>
Comment 10 Lucas Gass (lukeg) 2026-01-28 21:07:10 UTC
Created attachment 192136 [details] [review]
Bug 41700: Unit test

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io>
Comment 11 Lucas Gass (lukeg) 2026-01-28 21:08:02 UTC
Ive attached back tidied patches but you should mind your QA tools. ;)
Comment 12 Lucas Gass (lukeg) 2026-01-28 21:26:40 UTC
Nice work everyone!

Pushed to main for 26.05