| Summary: | Checkouts note_date has incorrect format in swagger definitions | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> |
| Component: | REST API | Assignee: | Nick Clemens (kidclamp) <nick> |
| Status: | Pushed to main --- | QA Contact: | Tomás Cohen Arazi (tcohen) <tomascohen> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | lucas, tomascohen |
| Version: | Main | Keywords: | rel_25_11_candidate |
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Crowdfunding committed: | 0 |
| Crowdfunding contact: | Patch complexity: | Trivial patch | |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
26.05.00
|
|
| Circulation function: | |||
| Attachments: |
Bug 41700: Update note_date to datetime
Bug 41700: Unit test Bug 41700: Update note_date to datetime Bug 41700: Unit test Bug 41700: Update note_date to datetime Bug 41700: Unit test Bug 41700: Update note_date to datetime Bug 41700: Unit test |
||
Created attachment 191985 [details] [review] Bug 41700: Update note_date to datetime This patch updates the swaager definition to have the correct format To test: 1 - Enable issue notes: AllowCheckoutNotes preference 2 - Issue an item to a patron 3 - Sign in to opac as that patron, add a note 4 - Have staff client open and a second tab try: http://localhost:8081/api/v1/checkouts/ 5 - Error "message":"Does not match date format.","path":"\/body\/0\/note_date" 6 - Apply patch, yarn build, restart all 7 - Refresh the page 8 - Success! Created attachment 191986 [details] [review] Bug 41700: Unit test Created attachment 191987 [details] [review] Bug 41700: Update note_date to datetime This patch updates the swaager definition to have the correct format To test: 1 - Enable issue notes: AllowCheckoutNotes preference 2 - Issue an item to a patron 3 - Sign in to opac as that patron, add a note 4 - Have staff client open and a second tab try: http://localhost:8081/api/v1/checkouts/ 5 - Error "message":"Does not match date format.","path":"\/body\/0\/note_date" 6 - Apply patch, yarn build, restart all 7 - Refresh the page 8 - Success! Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Created attachment 191988 [details] [review] Bug 41700: Unit test Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Trivial, but far reaching self SO Created attachment 192029 [details] [review] Bug 41700: Update note_date to datetime This patch updates the swaager definition to have the correct format To test: 1 - Enable issue notes: AllowCheckoutNotes preference 2 - Issue an item to a patron 3 - Sign in to opac as that patron, add a note 4 - Have staff client open and a second tab try: http://localhost:8081/api/v1/checkouts/ 5 - Error "message":"Does not match date format.","path":"\/body\/0\/note_date" 6 - Apply patch, yarn build, restart all 7 - Refresh the page 8 - Success! Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> Created attachment 192030 [details] [review] Bug 41700: Unit test Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> Trivial fix, QA script happy, tests pass. Thanks, Nick! Created attachment 192135 [details] [review] Bug 41700: Update note_date to datetime This patch updates the swaager definition to have the correct format To test: 1 - Enable issue notes: AllowCheckoutNotes preference 2 - Issue an item to a patron 3 - Sign in to opac as that patron, add a note 4 - Have staff client open and a second tab try: http://localhost:8081/api/v1/checkouts/ 5 - Error "message":"Does not match date format.","path":"\/body\/0\/note_date" 6 - Apply patch, yarn build, restart all 7 - Refresh the page 8 - Success! Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> Created attachment 192136 [details] [review] Bug 41700: Unit test Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> Ive attached back tidied patches but you should mind your QA tools. ;) Nice work everyone! Pushed to main for 26.05 |
note_date is defined as 'date' in checkout.yaml in the issues table it is a datetime. This is causing errors To recreate: 1 - Enable issue notes: AllowCheckoutNotes preference 2 - Issue an item to a patron 3 - Sign in to opac as that patron, add a note 4 - Have staff client open and a second tab try: http://localhost:8081/api/v1/checkouts/ 5 - Error "message":"Does not match date format.","path":"\/body\/0\/note_date"