Bug 41700

Summary: Checkouts note_date has incorrect format in swagger definitions
Product: Koha Reporter: Nick Clemens (kidclamp) <nick>
Component: REST APIAssignee: Bugs List <koha-bugs>
Status: Signed Off --- QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: tomascohen
Version: Main   
Hardware: All   
OS: All   
GIT URL: Initiative type: ---
Sponsorship status: --- Comma delimited list of Sponsors:
Crowdfunding goal: 0 Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:
Attachments: Bug 41700: Update note_date to datetime
Bug 41700: Unit test
Bug 41700: Update note_date to datetime
Bug 41700: Unit test

Description Nick Clemens (kidclamp) 2026-01-23 19:44:39 UTC
note_date is defined as 'date' in checkout.yaml
in the issues table it is a datetime. This is causing errors

To recreate:
1 - Enable issue notes:  AllowCheckoutNotes preference
2 - Issue an item to a patron
3 - Sign in to opac as that patron, add a note
4 - Have staff client open and a second tab try:
    http://localhost:8081/api/v1/checkouts/
5 - Error "message":"Does not match date format.","path":"\/body\/0\/note_date"
Comment 1 Nick Clemens (kidclamp) 2026-01-23 19:55:35 UTC
Created attachment 191985 [details] [review]
Bug 41700: Update note_date to datetime

This patch updates the swaager definition to have the correct format

To test:
1 - Enable issue notes:  AllowCheckoutNotes preference
2 - Issue an item to a patron
3 - Sign in to opac as that patron, add a note
4 - Have staff client open and a second tab try:
    http://localhost:8081/api/v1/checkouts/
5 - Error "message":"Does not match date format.","path":"\/body\/0\/note_date"
6 - Apply patch, yarn build, restart all
7 - Refresh the page
8 - Success!
Comment 2 Nick Clemens (kidclamp) 2026-01-23 19:55:38 UTC
Created attachment 191986 [details] [review]
Bug 41700: Unit test
Comment 3 Nick Clemens (kidclamp) 2026-01-23 19:55:59 UTC
Created attachment 191987 [details] [review]
Bug 41700: Update note_date to datetime

This patch updates the swaager definition to have the correct format

To test:
1 - Enable issue notes:  AllowCheckoutNotes preference
2 - Issue an item to a patron
3 - Sign in to opac as that patron, add a note
4 - Have staff client open and a second tab try:
    http://localhost:8081/api/v1/checkouts/
5 - Error "message":"Does not match date format.","path":"\/body\/0\/note_date"
6 - Apply patch, yarn build, restart all
7 - Refresh the page
8 - Success!

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 4 Nick Clemens (kidclamp) 2026-01-23 19:56:01 UTC
Created attachment 191988 [details] [review]
Bug 41700: Unit test

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 5 Nick Clemens (kidclamp) 2026-01-23 19:56:22 UTC
Trivial, but far reaching self SO