| Summary: | ", by" in suggestions is untranslatable | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Caroline Cyr La Rose <caroline.cyr-la-rose> |
| Component: | I18N/L10N | Assignee: | Ayoub Glizi-Vicioso <ayoub.glizi-vicioso> |
| Status: | Failed QA --- | QA Contact: | Katrin Fischer <katrin.fischer> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | david, f.demians, jonathan.druart, raymund.delahunty |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | 33430 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 41769: Make ', by' string translatable in suggestions
Bug 41769: Make ', by' string translatable in suggestions Bug 41769: Make ', by' string translatable in suggestions Bug 41769: Make ', by' string translatable in suggestions |
||
|
Description
Caroline Cyr La Rose
2026-02-04 16:13:01 UTC
Created attachment 192541 [details] [review] Bug 41769: Make ', by' string translatable in suggestions To test: 1. Add another language to Koha ./misc/translator/translate install fr-CA 2. Enable the new language in StaffInterfaceLanguages 2.1. Go to Administration > System preferences 2.2. Search for StaffInterfaceLanguages 2.3. Check the new language 2.4. Click Save all I18N/L10N preferences 3. Create a new purchase suggestion 3.1. Go to More > Suggestions 3.2. Click New purchase suggestion 3.3. Fill out the title AND the author at least 3.4. Click Submit your suggestion 4. View the suggestion in the table --> It says title, by author 5. Switch language --> The ", by" is still in English 6. Apply patch. 7. Reload page. 8. Notice that ", by" is now translated. --> in this instance, you will see ", par" Created attachment 192545 [details] [review] Bug 41769: Make ', by' string translatable in suggestions To test: 1. Add another language to Koha ./misc/translator/translate install fr-CA 2. Enable the new language in StaffInterfaceLanguages 2.1. Go to Administration > System preferences 2.2. Search for StaffInterfaceLanguages 2.3. Check the new language 2.4. Click Save all I18N/L10N preferences 3. Create a new purchase suggestion 3.1. Go to More > Suggestions 3.2. Click New purchase suggestion 3.3. Fill out the title AND the author at least 3.4. Click Submit your suggestion 4. View the suggestion in the table --> It says title, by author 5. Switch language --> The ", by" is still in English 6. Apply patch. 7. Reload page. 8. Notice that ", by" is now translated. --> in this instance, you will see ", par" Signed-off-by: David Nind <david@davidnind.com> Testing notes (using KTD): 1. After applying the patch you need to update the translation (this worked for me, not sure if both steps required): . ./misc/translator/translate update fr-CA . ./misc/translator/translate install fr-CA (In reply to David Nind from comment #3) > Testing notes (using KTD): > > 1. After applying the patch you need to update the translation (this worked > for me, not sure if both steps required): > . ./misc/translator/translate update fr-CA > . ./misc/translator/translate install fr-CA Yes indeed, i forgot to specify. Created attachment 192546 [details] [review] Bug 41769: Make ', by' string translatable in suggestions To test: 1. Add another language to Koha ./misc/translator/translate install fr-CA 2. Enable the new language in StaffInterfaceLanguages 2.1. Go to Administration > System preferences 2.2. Search for StaffInterfaceLanguages 2.3. Check the new language 2.4. Click Save all I18N/L10N preferences 3. Create a new purchase suggestion 3.1. Go to More > Suggestions 3.2. Click New purchase suggestion 3.3. Fill out the title AND the author at least 3.4. Click Submit your suggestion 4. View the suggestion in the table --> It says title, by author 5. Switch language --> The ", by" is still in English 6. Apply patch. 7. run those command: --> ./misc/translator/translate update fr-CA --> ./misc/translator/translate install fr-CA 8. Reload page. 9. Notice that ", by" is now translated. --> in this instance, you will see ", par" Signed-off-by: David Nind <david@davidnind.com> (In reply to Ayoub Glizi-Vicioso from comment #4) > (In reply to David Nind from comment #3) > > Testing notes (using KTD): > > > > 1. After applying the patch you need to update the translation (this worked > > for me, not sure if both steps required): > > . ./misc/translator/translate update fr-CA > > . ./misc/translator/translate install fr-CA > > Yes indeed, i forgot to specify. No problem! 8-) Created attachment 192579 [details] [review] Bug 41769: Make ', by' string translatable in suggestions To test: 1. Add another language to Koha ./misc/translator/translate install fr-CA 2. Enable the new language in StaffInterfaceLanguages 2.1. Go to Administration > System preferences 2.2. Search for StaffInterfaceLanguages 2.3. Check the new language 2.4. Click Save all I18N/L10N preferences 3. Create a new purchase suggestion 3.1. Go to More > Suggestions 3.2. Click New purchase suggestion 3.3. Fill out the title AND the author at least 3.4. Click Submit your suggestion 4. View the suggestion in the table --> It says title, by author 5. Switch language --> The ", by" is still in English 6. Apply patch. 7. run those command: --> ./misc/translator/translate update fr-CA --> ./misc/translator/translate install fr-CA 8. Reload page. 9. Notice that ", by" is now translated. --> in this instance, you will see ", par" Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Ray Delahunty <Raymund.delahunty@outlook.com> Whether my signoff is valid or not is for others to decide, as I only used a sandbox, not this KTD. (Reading and learning about the KTD is on this weekend's 'to do list'). Rather than run the update of the already installed language pack, I ran patch in the sandbox and then installed the language, and 'by' was 'von' for the DE language option. I believe this works, but I wonder about the empty parameters:
node += _("%s%s, by %s%s").format("", "", row.author.escapeHtml(), "")
Why the additional %s?
Why not:
node += _(", by %s").format(row.author.escapeHtml())
|