Bug 41861

Summary: ILL request cost and price paid don't show if 0
Product: Koha Reporter: Pedro Amorim <pedro.amorim>
Component: ILLAssignee: Pedro Amorim <pedro.amorim>
Status: Signed Off --- QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: andrew.auld, david, edith.speller, jeremy.evans, lisette, martin.renvoize, pedro.amorim, tomascohen
Version: MainKeywords: rel_25_11_candidate
Hardware: All   
OS: All   
GIT URL: Initiative type: ---
Sponsorship status: --- Comma delimited list of Sponsors:
Crowdfunding goal: 0 Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
This updates how an ILL request cost and price paid are shown - if the amount is $0, then it is now shown. Previously, the fields were not shown if the amount was $0. (Note: 'Cost' is not editable in the user interface, but the backend used may set the value. 'Price paid' is editable through the 'Edit request' action)
Version(s) released in:
Circulation function:
Attachments: Bug 41861: Update how cost and price_paid show
Bug 41861: Update how cost and price_paid show
Bug 41861: Update how cost and price_paid show

Description Pedro Amorim 2026-02-17 10:19:14 UTC

    
Comment 1 Pedro Amorim 2026-02-17 10:21:04 UTC
Created attachment 193316 [details] [review]
Bug 41861: Update how cost and price_paid show

1) Enabled ILLModule
2) Create a new ILL request, set a title, '42' for cardnumber and any library:
<staff_url>/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard
3) (k-t-d required, cost is not editable in UI, but backends may set it) Run the following query:
koha-mysql kohadev
update illrequests set cost = 1;
4) Notice cost shows, now run the same but set to 0:
update illrequests set cost = 1;
5) Notice it doesn't show.
6) Apply patch. Refresh. Notice is shows '0' now.
Comment 2 David Nind 2026-02-18 21:50:28 UTC
Created attachment 193366 [details] [review]
Bug 41861: Update how cost and price_paid show

1) Enabled ILLModule
2) Create a new ILL request, set a title, '42' for cardnumber and any library:
<staff_url>/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard
3) (k-t-d required, cost is not editable in UI, but backends may set it) Run the following query:
koha-mysql kohadev
update illrequests set cost = 1;
4) Notice cost shows, now run the same but set to 0:
update illrequests set cost = 1;
5) Notice it doesn't show.
6) Apply patch. Refresh. Notice is shows '0' now.
Comment 3 Pedro Amorim 2026-02-19 15:26:00 UTC
Created attachment 193486 [details] [review]
Bug 41861: Update how cost and price_paid show

1) Enabled ILLModule
2) Create a new ILL request, set a title, '42' for cardnumber and any library:
<staff_url>/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard
3) (k-t-d required, cost is not editable in UI, but backends may set it) Run the following query:
koha-mysql kohadev
update illrequests set cost = 1;
4) Notice cost shows, now run the same but set to 0:
update illrequests set cost = 1;
5) Notice it doesn't show.
6) Apply patch. Refresh. Notice is shows '0' now.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Edith Speller <edith.speller@ukhsa.gov.uk>
Comment 4 Pedro Amorim 2026-02-19 15:26:50 UTC
David I've added a sign-off line for our customer who has tested this.
I've also added yours as it appears you signed off but didn't add your line. Let me know if not please. Thanks.
Comment 5 David Nind 2026-02-19 17:16:51 UTC
(In reply to Pedro Amorim from comment #4)
> David I've added a sign-off line for our customer who has tested this.
> I've also added yours as it appears you signed off but didn't add your line.
> Let me know if not please. Thanks.

Thanks Pedro! Not sure why I missed doing that! (And thanks for the edit to the release note.)